Re: [STLinux Kernel] [PATCH 4/7] ARM: stih416-b2020e: Enable PWM on the B2020 Rev-E

Lee Jones
2014-06-19T09:20:42Z

> > All the infrastructure is now in place for ST's PWM controller. This
> > patch takes the final step and enables the IP on the 2020 Rev-E
> > development platform.
>
> Why are you only enabling this for rev-E board?

Purely for testing purposes, as it's the only board I have. If
anyone has the other revisions and would be happy to test the driver
for me then great.

> If you make the stih415 DT PWM nodes part of this series as well, then
> assuming there is no good reason to the contary, the PWM could
> be enabled for both stih415/6 in the common stih41x-b2020 DTS file which
> is also included by rev-E (assuming that PWM wiring is not some rev-E specific
> thing).
>
> Also Ajit Signed-off-by needs adding to this series.

As you know, Thierry already picked this up.

Will fix for v2.

> After that:
> Acked-by: Peter Griffin <peter.griffin@linaro.org>

Thanks.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog