Re: [STLinux Kernel] [PATCH 1/7] ARM: stih407: Add DT nodes for for PWM

Peter Griffin
2014-06-19T08:38:40Z

Hi Lee,

> + /* SBC PWM Module */
> + pwm1: pwm@9510000 {
> + compatible = "st,sti-pwm";
> + status = "disabled";
> + #pwm-cells = <2>;
> + reg = <0x9510000 0x68>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_pwm1_chan0_default
> + &pinctrl_pwm1_chan1_default
> + &pinctrl_pwm1_chan2_default
> + &pinctrl_pwm1_chan3_default>;

If you're passing pin config for 4 channels, I think you should also be using the
'st,pwm-num-chan = <4>' property like the doc example in patch 7.

After that:
Acked-by: Peter Griffin <peter.griffin@linaro.org>

regards,

Peter.