Re: [PATCH 3/3] ARM: at91/tclib: mask interruptions at shutdown and probe

Arnd Bergmann
2014-08-21T03:33:45Z

On Wednesday 20 August 2014, Gaël PORTAY wrote:
> +static void tc_shutdown (struct platform_device *pdev)
> +{
> + int i;
> + struct atmel_tc *tc = platform_get_drvdata(pdev);
> +
> + for (i = 0; i < 3; i++)
> + __raw_writel(0xff, tc->regs + ATMEL_TC_REG(i, IDR));
> +}

In general, __raw_readl/__raw_writel are not meant to be called by device drivers.

Just use readl/writel by default, or readl_relaxed/writel_relaxed if the code is
performance critical and you are sure it is safe to use them.

Arnd