From: Thierry Reding <thierry.reding@gmail.com>
To: Alan Cox <alan@linux.intel.com>
Cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
linux-pwm@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v4 0/2] pwm: lpss: split driver to core and probe drivers
Date: Thu, 21 Aug 2014 08:43:06 +0200 [thread overview]
Message-ID: <20140821064305.GD4486@ulmo> (raw)
In-Reply-To: <1408557479.3270.8.camel@acox1-desk.ger.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1834 bytes --]
On Wed, Aug 20, 2014 at 06:57:59PM +0100, Alan Cox wrote:
> On Wed, 2014-08-20 at 12:12 +0200, Thierry Reding wrote:
> > On Tue, Aug 19, 2014 at 07:17:34PM +0300, Andy Shevchenko wrote:
> > > This small series makes the architecture of pwm-lpss driver cleaner.
> > >
> > > Since v3:
> > > - rebased on top of recent linux-next
> > > - rebased on top of Alan's patch for Braswell
> > >
> > > Since v2:
> > > - fix one more typo in Kconfig (tested with one line removed in my config now)
> > >
> > > Since v1:
> > > - hide struct definition in the core part
> > > - rename pwm-lpss-plat to pwm-lpss-platform
> > > - fix Kconfig dependencies and other typos
> > > - add Mika's Reviewed-by tag
> > > - fix spelling in the commit messages
> > >
> > > Andy Shevchenko (2):
> > > pwm: lpss: properly split driver to parts
> > > pwm: lpss: pci: move to use pcim_enable_device()
> > >
> > > drivers/pwm/Kconfig | 21 ++++++-
> > > drivers/pwm/Makefile | 2 +
> > > drivers/pwm/pwm-lpss-pci.c | 65 +++++++++++++++++++
> > > drivers/pwm/pwm-lpss-platform.c | 69 ++++++++++++++++++++
> > > drivers/pwm/pwm-lpss.c | 136 +++-------------------------------------
> > > drivers/pwm/pwm-lpss.h | 32 ++++++++++
> > > 6 files changed, 198 insertions(+), 127 deletions(-)
> > > create mode 100644 drivers/pwm/pwm-lpss-pci.c
> > > create mode 100644 drivers/pwm/pwm-lpss-platform.c
> > > create mode 100644 drivers/pwm/pwm-lpss.h
> >
> > Yea or nay, Alan?
>
> Context ?
Back when the LPSS PWM driver was first submitted I suggested that it
could be split up in this way (core + PCI and ACPI/platform drivers).
You had objections to doing that. Now Andy's doing exactly that, so I
would like your Acked-by (or NAK) on this change.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-08-21 6:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 16:17 [PATCH v4 0/2] pwm: lpss: split driver to core and probe drivers Andy Shevchenko
2014-08-19 16:17 ` [PATCH v4 1/2] pwm: lpss: properly split driver to parts Andy Shevchenko
2014-08-22 11:13 ` Thierry Reding
2014-08-25 8:11 ` Andy Shevchenko
2014-08-25 9:28 ` Thierry Reding
2014-08-19 16:17 ` [PATCH v4 2/2] pwm: lpss: pci: move to use pcim_enable_device() Andy Shevchenko
2014-08-20 10:12 ` [PATCH v4 0/2] pwm: lpss: split driver to core and probe drivers Thierry Reding
2014-08-20 17:57 ` Alan Cox
2014-08-21 6:43 ` Thierry Reding [this message]
2014-08-21 14:20 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821064305.GD4486@ulmo \
--to=thierry.reding@gmail.com \
--cc=alan@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=linux-pwm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).