From: Thierry Reding <thierry.reding@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-pwm@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH v4 1/2] pwm: lpss: properly split driver to parts
Date: Fri, 22 Aug 2014 13:13:44 +0200 [thread overview]
Message-ID: <20140822111343.GA3825@ulmo> (raw)
In-Reply-To: <1408465056-8605-2-git-send-email-andriy.shevchenko@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 970 bytes --]
On Tue, Aug 19, 2014 at 07:17:35PM +0300, Andy Shevchenko wrote:
[...]
> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
[...]
> +config PWM_LPSS_PCI
> + tristate "Intel LPSS PWM PCI driver"
> + depends on PCI
> + select PWM_LPSS
[...]
> +config PWM_LPSS_PLATFORM
> + tristate "Intel LPSS PWM platform driver"
> + depends on ACPI
> + select PWM_LPSS
I changed both of the above select PWM_LPSS to depends on PWM_LPSS
because that makes them show up in a more meaningful way in menuconfig
and otherwise it looks weird if the PWM_LPSS shows up as automatically
selected without being useful in itself. This way the PWM_LPSS is sort
of a common core that PWM_LPSS_PLATFORM and PWM_LPSS_PCI use.
An alternative that's commonly used for this would be to hide PWM_LPSS
from users and keep the select within PWM_LPSS_PLATFORM and
PWM_LPSS_PCI. That would be okay with me too.
Let me know if you have any objections to this change.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-08-22 11:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 16:17 [PATCH v4 0/2] pwm: lpss: split driver to core and probe drivers Andy Shevchenko
2014-08-19 16:17 ` [PATCH v4 1/2] pwm: lpss: properly split driver to parts Andy Shevchenko
2014-08-22 11:13 ` Thierry Reding [this message]
2014-08-25 8:11 ` Andy Shevchenko
2014-08-25 9:28 ` Thierry Reding
2014-08-19 16:17 ` [PATCH v4 2/2] pwm: lpss: pci: move to use pcim_enable_device() Andy Shevchenko
2014-08-20 10:12 ` [PATCH v4 0/2] pwm: lpss: split driver to core and probe drivers Thierry Reding
2014-08-20 17:57 ` Alan Cox
2014-08-21 6:43 ` Thierry Reding
2014-08-21 14:20 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140822111343.GA3825@ulmo \
--to=thierry.reding@gmail.com \
--cc=alan@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=linux-pwm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).