Re: [PATCH] PWM: atmel: fix incorrect CDTY value after enabling or disabling

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]

On Fri, Mar 14, 2014 at 08:05:31PM +0100, Alexandre Belloni wrote:
> pwm-leds calls .config() and .disable() in a row. This exhibits that it may
> happen that the channel gets disabled before CDTY has been updated with CUPD.
> The issue gets quite worse with long periods.
> So, ensure by reading ISR that at least one period has past before disabling the
> channel.
> 
> The other issue is that it may happen that CUPD is not flushed before enabling
> the channel so it will update CDTY/CPRD just after one period. So we always set
> CUPD, even when the channel is not enabled.
> 
> Tested on at91sam9g45 and sama5d31ek.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
>  drivers/pwm/pwm-atmel.c | 46 +++++++++++++++++++++++++++++-----------------
>  1 file changed, 29 insertions(+), 17 deletions(-)

Hi Alexandre,

going through the list of unapplied patches I came across this old
patch. It was never reviewed nor acked by anyone and you didn't ping me,
so I always assumed it must no longer be required. Is that so?

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]