From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Eremin-Solenikov <dmitry_eremin@mentor.com>
Cc: Shawn Guo <shawn.guo@linaro.org>,
Liu Ying <Ying.Liu@freescale.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-pwm@vger.kernel.org
Subject: Re: [PATCH] pwm: imx: don't reprogram PWMSAR if PWM is disabled
Date: Mon, 25 Aug 2014 15:56:53 +0200 [thread overview]
Message-ID: <20140825135652.GL4163@ulmo.nvidia.com> (raw)
In-Reply-To: <53E09A69.5000806@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]
On Tue, Aug 05, 2014 at 04:48:41PM +0800, Liu Ying wrote:
> On 08/05/2014 09:36 AM, Shawn Guo wrote:
> >On Fri, Aug 01, 2014 at 10:02:17PM +0400, Dmitry Eremin-Solenikov wrote:
> >>On Wed, Jul 23, 2014 at 12:09 PM, Dmitry Eremin-Solenikov
> >><dbaryshkov@gmail.com> wrote:
> >>>From: Dmitry Eremin-Solenikov <dmitry_eremin@mentor.com>
> >>>
> >>>Writing several values to PWMSAR register with PWM being disabled can
> >>>lead to FIFO (connected to PWMSAR) being overflown. Then after enabling
> >>>PWM, hardware will use stale values. Instead cache the duty cycles and
> >>>write them to the hardware only before enabling PWM.
> >>
> >>What about this patch?
> >
> >Copy Liu Ying who seems to have a patch [1] addressing the same problem?
> >
>
> Yes, my patch may address the same problem. And, my patch may cache the last
> duty cycle as well when the PWM is disabled. The difference is that my patch
> caches it in the register PWMSAR instead of a variable.
Dmitry,
I've just pushed Liu's patch that might fix this problem. Can you give
it a quick spin to see if it fixes the issue that you're seeing? It's in
the for-next branch of the PWM tree[0].
Thanks,
Thierry
[0]: git://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm.git
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-08-25 13:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 8:09 [PATCH] pwm: imx: don't reprogram PWMSAR if PWM is disabled Dmitry Eremin-Solenikov
2014-08-01 18:02 ` Dmitry Eremin-Solenikov
2014-08-05 0:47 ` Dmitry Eremin-Solenikov
2014-08-05 1:36 ` Shawn Guo
2014-08-05 8:48 ` Liu Ying
2014-08-25 13:56 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825135652.GL4163@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=Ying.Liu@freescale.com \
--cc=dmitry_eremin@mentor.com \
--cc=linux-pwm@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).