From: Thierry Reding <thierry.reding@gmail.com>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/pwm/Kconfig: Let PWM_CLPS711X depend on HAS_IOMEM
Date: Mon, 6 Oct 2014 12:08:42 +0200 [thread overview]
Message-ID: <20141006100842.GC25202@ulmo> (raw)
In-Reply-To: <542FC27A.8050006@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]
On Sat, Oct 04, 2014 at 05:48:42PM +0800, Chen Gang wrote:
> PWM_CLPS711X needs HAS_IOMEM, so depend on it, the related error (with
> allmodconfig under um):
>
> MODPOST 1205 modules
> ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined!
> ERROR: "devm_ioremap" [drivers/net/phy/mdio-bcm-unimac.ko] undefined!
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> drivers/pwm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> index 3865dfb..de1ffb5 100644
> --- a/drivers/pwm/Kconfig
> +++ b/drivers/pwm/Kconfig
> @@ -82,7 +82,7 @@ config PWM_BFIN
>
> config PWM_CLPS711X
> tristate "CLPS711X PWM support"
> - depends on ARCH_CLPS711X || COMPILE_TEST
> + depends on (ARCH_CLPS711X || COMPILE_TEST) && HAS_IOMEM
Applied, thanks. I modified this slightly and put HAS_IOMEM on a line of
its own. This is in my opinion (slightly) more readable and matches what
we already have for other drivers.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-10-06 10:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-04 9:48 [PATCH] drivers/pwm/Kconfig: Let PWM_CLPS711X depend on HAS_IOMEM Chen Gang
2014-10-06 10:08 ` Thierry Reding [this message]
2014-10-06 13:07 ` Chen Gang
-- strict thread matches above, loose matches on Subject: below --
2014-07-13 11:49 Chen Gang
2014-07-14 8:18 ` Thierry Reding
2014-07-14 9:14 ` Chen Gang
2014-07-14 9:33 ` Thierry Reding
2014-07-14 10:00 ` Chen Gang
2014-07-23 11:51 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141006100842.GC25202@ulmo \
--to=thierry.reding@gmail.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).