From mboxrd@z Thu Jan 1 00:00:00 1970 From: One Thousand Gnomes Subject: Re: [PATCH v8 1/2] pwm: Imagination Technologies PWM DAC driver Date: Mon, 12 Jan 2015 21:04:22 +0000 Message-ID: <20150112210422.39f715a2@lxorguk.ukuu.org.uk> References: <1420826088-13113-1-git-send-email-ezequiel.garcia@imgtec.com> <1420826088-13113-2-git-send-email-ezequiel.garcia@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from 251.110.2.81.in-addr.arpa ([81.2.110.251]:41792 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753420AbbALVEn (ORCPT ); Mon, 12 Jan 2015 16:04:43 -0500 In-Reply-To: <1420826088-13113-2-git-send-email-ezequiel.garcia@imgtec.com> Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: Ezequiel Garcia Cc: Andrew Bresticker , Thierry Reding , James Hartley , Arnd Bergmann , Greg Kroah-Hartman , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, vladimir_zapolskiy@mentor.com, Naidu Tellapati , Naidu Tellapati , Sai Masarapu > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); What if you've not been given a resource ? Otherwise looks fine to me