From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [RFC PATCH 00/15] pwm: add support for atomic update Date: Thu, 2 Jul 2015 09:03:43 +0200 Message-ID: <20150702070343.GD11824@pengutronix.de> References: <1435738921-25027-1-git-send-email-boris.brezillon@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]:55484 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753376AbbGBHEK (ORCPT ); Thu, 2 Jul 2015 03:04:10 -0400 Content-Disposition: inline In-Reply-To: <1435738921-25027-1-git-send-email-boris.brezillon@free-electrons.com> Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: Boris Brezillon Cc: Thierry Reding , linux-pwm@vger.kernel.org, Alexandre Courbot , linux-fbdev@vger.kernel.org, Lee Jones , Stephen Warren , Tomi Valkeinen , Bryan Wu , Liam Girdwood , Doug Anderson , Mark Brown , Richard Purdie , linux-arm-kernel@lists.infradead.org, Jingoo Han , linux-tegra@vger.kernel.org, Maxime Ripard , Jean-Christophe Plagniol-Villard , Jacek Anaszewski , linux-leds@vger.kernel.org Hello Boris, On Wed, Jul 01, 2015 at 10:21:46AM +0200, Boris Brezillon wrote: > This series adds support for atomic PWM update, or ITO, the capabilit= y > to update all the parameters of a PWM device (enabled/disabled, perio= d, > duty and polarity) in one go. on first reading the subject of your series I thought it was about asserting that the newly set config is active before the call to pwm_config (et al) returns. That's a problem I addressed a few times in the past. I wonder if it's only me or if a different wording should be used for "update all parameters with a single function call". But other than that I like the series. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig = | Industrial Linux Solutions | http://www.pengutronix.de/= |