From: Clemens Gruber <clemens.gruber@pqgruber.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-pwm@vger.kernel.org
Subject: Re: [PATCH v3 2/2] pwm-pca9685: Support changing the output frequency
Date: Mon, 20 Jul 2015 14:31:18 +0200 [thread overview]
Message-ID: <20150720123118.GA28687@pqgruber.com> (raw)
In-Reply-To: <20150720095813.GU29614@ulmo>
On Mon, Jul 20, 2015 at 11:58:14AM +0200, Thierry Reding wrote:
> I guess it depends a bit on what the typical use-cases are for this
> chip. Is it usually used only for LEDs (the register names suggest it)?
> If so, how likely is it that people will want to drive them at different
> periods? If it's reasonable to require the same period for all of them,
> maybe it would be worth adding some sort of WARN_ON() or dev_warn() or
> something to notify integrators of this fact.
Not likely. If they read the datasheet of the PCA9685, they should know that
this is not even possible with that chip.
On what condition would you WARN / dev_warn in this case? If the user tries to
set different prescaler values to different channels?
Clemens
prev parent reply other threads:[~2015-07-20 12:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 8:36 [PATCH v3 0/2] pwm-pca9685: Bugfixes and prescaler support Clemens Gruber
2015-07-20 8:36 ` [PATCH v3 1/2] pwm-pca9685: Fix several driver bugs Clemens Gruber
2015-07-20 9:27 ` Thierry Reding
2015-07-20 9:31 ` Thierry Reding
2015-07-20 8:36 ` [PATCH v3 2/2] pwm-pca9685: Support changing the output frequency Clemens Gruber
2015-07-20 9:30 ` Thierry Reding
2015-07-20 9:46 ` Clemens Gruber
2015-07-20 9:50 ` Clemens Gruber
2015-07-20 9:58 ` Thierry Reding
2015-07-20 12:15 ` Clemens Gruber
2015-07-20 12:31 ` Clemens Gruber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720123118.GA28687@pqgruber.com \
--to=clemens.gruber@pqgruber.com \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).