From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: Re: [PATCH] pwm: don't allow duty cycle higher than period Date: Fri, 27 May 2016 09:50:37 -0700 Message-ID: <20160527165037.GA112338@google.com> References: <1464296730-121773-1-git-send-email-briannorris@chromium.org> <20160527093439.5ad237c5@bbrezillon> <20160527163533.GA80118@google.com> <20160527183814.6f8f4ba7@bbrezillon> <20160527163943.GB80118@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pf0-f176.google.com ([209.85.192.176]:34258 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753676AbcE0Quk (ORCPT ); Fri, 27 May 2016 12:50:40 -0400 Received: by mail-pf0-f176.google.com with SMTP id y69so43322745pfb.1 for ; Fri, 27 May 2016 09:50:40 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20160527163943.GB80118@google.com> Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: Boris Brezillon Cc: Thierry Reding , linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Norris , Doug Anderson On Fri, May 27, 2016 at 09:39:43AM -0700, Brian Norris wrote: > On Fri, May 27, 2016 at 06:38:14PM +0200, Boris Brezillon wrote: > > On Fri, 27 May 2016 09:35:33 -0700 > > Brian Norris wrote: > > > On Fri, May 27, 2016 at 09:34:39AM +0200, Boris Brezillon wrote: > > > Now that you mention it, I think you've also dropped some signed > > > (negative value) checking in pwm_config(). I'll squash in your diff + > > > some pwm_config() fixes. > > > > ->period and ->duty_cycle are unsigned now ;). > > Not in pwm_config(). And we don't want to implitly make thos into large I really can't spell today... two typos in the same sentence! > unsigned values. Brian