From: Brian Norris <briannorris@chromium.org>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Thierry Reding <thierry.reding@gmail.com>,
Linux PWM List <linux-pwm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Brian Norris <computersforpeace@gmail.com>,
Doug Anderson <dianders@chromium.org>,
linux-renesas-soc@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v2] pwm: improve args checking in pwm_apply_state()
Date: Wed, 22 Jun 2016 13:46:48 -0700 [thread overview]
Message-ID: <20160622204647.GA14996@google.com> (raw)
In-Reply-To: <20160622224114.697c0db5@bbrezillon>
On Wed, Jun 22, 2016 at 10:41:14PM +0200, Boris Brezillon wrote:
> On Wed, 22 Jun 2016 12:16:59 -0700
> Brian Norris <briannorris@chromium.org> wrote:
> > Notably, you're dropping the 'if (!pwm) { }' safety checks that are part
> > of pwm_disable() and pwm_set_polarity(). But I don't think there should
> > be any users relying on that.
>
> Indeed. I can add it back here if you prefer,
Nah, that's ok. I just had to say it anyway :)
> but honestly, PWM users
> that are not checking the value returned by pwm_get() should be
> considered buggy IMHO, and a NULL pointer exception is a good way to
> make people realize they are not properly using the API :).
Seems OK.
Brian
next prev parent reply other threads:[~2016-06-22 20:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 16:45 [PATCH v2] pwm: improve args checking in pwm_apply_state() Brian Norris
2016-05-27 16:54 ` Boris Brezillon
2016-06-10 12:20 ` Thierry Reding
2016-06-21 14:42 ` Geert Uytterhoeven
2016-06-21 18:37 ` Brian Norris
2016-06-21 21:22 ` Boris Brezillon
2016-06-22 8:04 ` Boris Brezillon
2016-06-22 12:00 ` Thierry Reding
2016-06-22 14:32 ` Geert Uytterhoeven
2016-06-22 19:16 ` Brian Norris
2016-06-22 20:41 ` Boris Brezillon
2016-06-22 20:46 ` Brian Norris [this message]
2016-06-23 16:55 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160622204647.GA14996@google.com \
--to=briannorris@chromium.org \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dianders@chromium.org \
--cc=geert@linux-m68k.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).