Re: [PATCH] pwm: twl: Reliably disable TWL6030 PWMs

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]

On Tue, Mar 29, 2016 at 08:55:45PM +0200, Paul Kocialkowski wrote:
> The current TWL6030 code for the TWL PWM driver does not reliably disable the
> PWM output, as tested with LEDs. The previous commit to that driver introduced
> that regression.
> 
> However, it does make sense to disable the PWM clock after resetting the PWM,
> but for some obscure reason, doing it all at once simply doesn't work.
> 
> The TWL6030 datasheet mentions that PWMs have to be disabled in two distinct
> steps. However, clearing the clock enable bit in a second step (after issuing a
> reset first) does not work.
> 
> The only approach that works is the one that was in place before the previous
> commit to the driver. It consists in enabling the PWM clock after issuing a
> reset. This is what TI kernel trees and production code seem to be using.
> 
> However, adding an extra step to disable the PWM clock seems to work reliably,
> despite looking quite odd.
> 
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
>  drivers/pwm/pwm-twl.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)

Applied, thanks.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]