From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v4 2/2] backlight: pwm_bl: Check the PWM state for initial backlight power state Date: Fri, 9 Dec 2016 09:14:06 +0000 Message-ID: <20161209091406.GF3625@dell.home> References: <20161122134123.1209-1-peter.ujfalusi@ti.com> <20161122134123.1209-3-peter.ujfalusi@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20161122134123.1209-3-peter.ujfalusi@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Peter Ujfalusi Cc: thierry.reding@gmail.com, tomi.valkeinen@ti.com, linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de List-Id: linux-pwm@vger.kernel.org On Tue, 22 Nov 2016, Peter Ujfalusi wrote: > If the PWM is not enabled the backlight initially should not be enabled > either if we have booted with DT and there is a phandle pointing to the > backlight node. > > The patch extends the checks to decide if we should keep the backlight off > initially. > > Signed-off-by: Peter Ujfalusi > Acked-by: Philipp Zabel > Reviewed-by: Thierry Reding > --- > drivers/video/backlight/pwm_bl.c | 4 ++++ > 1 file changed, 4 insertions(+) Applied for v4.11, thanks. > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c > index 5712ddd053dd..d7efcb632f7d 100644 > --- a/drivers/video/backlight/pwm_bl.c > +++ b/drivers/video/backlight/pwm_bl.c > @@ -215,6 +215,10 @@ static int pwm_backlight_initial_power_state(const struct pwm_bl_data *pb) > if (!regulator_is_enabled(pb->power_supply)) > return FB_BLANK_POWERDOWN; > > + /* The PWM is disabled, keep it like this */ > + if (!pwm_is_enabled(pb->pwm)) > + return FB_BLANK_POWERDOWN; > + > return FB_BLANK_UNBLANK; > } > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog