From: Thierry Reding <thierry.reding@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-pwm@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ilkka Koskinen <ilkka.koskinen@intel.com>
Subject: Re: [PATCH v2 3/4] pwm: lpss: Do not export board infos for different PWM types
Date: Wed, 18 Jan 2017 12:11:09 +0100 [thread overview]
Message-ID: <20170118111109.GO18989@ulmo.ba.sec> (raw)
In-Reply-To: <20170102091647.86910-4-andriy.shevchenko@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1152 bytes --]
On Mon, Jan 02, 2017 at 11:16:46AM +0200, Andy Shevchenko wrote:
> From: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> The PWM LPSS probe drivers just pass a pointer to the exported board info
> structures to pwm_lpss_probe() based on device PCI or ACPI ID. Since the
> core driver knows everything else except mapping between device ID and the
> type, just pass the type with pwm_lpss_probe() and stop exporting the board
> info structures.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> drivers/pwm/pwm-lpss-pci.c | 20 ++++++++---------
> drivers/pwm/pwm-lpss-platform.c | 10 ++++-----
> drivers/pwm/pwm-lpss.c | 49 ++++++++++++++++++++++-------------------
> drivers/pwm/pwm-lpss.h | 14 +++++-------
> 4 files changed, 44 insertions(+), 49 deletions(-)
Is there anything in particular that you think will need this change? It
looks to me more like churn than anything else. Moving away from the per
device struct to describe the particular instance seems to me like
removing flexibility that we might want at some point rather than any
real gain.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-01-18 11:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 9:16 [PATCH v2 0/4] pwm: lpss: clean up series Andy Shevchenko
2017-01-02 9:16 ` [PATCH v2 1/4] pwm: lpss: Avoid potential overflow of base_unit Andy Shevchenko
2017-01-02 9:16 ` [PATCH v2 2/4] pwm: lpss: Allow duty cycle to be 0 Andy Shevchenko
2017-01-02 9:16 ` [PATCH v2 3/4] pwm: lpss: Do not export board infos for different PWM types Andy Shevchenko
2017-01-18 11:11 ` Thierry Reding [this message]
2017-01-18 13:01 ` Mika Westerberg
2017-01-20 11:00 ` Thierry Reding
2017-01-20 11:15 ` Mika Westerberg
2017-01-20 11:18 ` Thierry Reding
2017-01-02 9:16 ` [PATCH v2 4/4] pwm: lpss: Switch to new atomic API Andy Shevchenko
2017-01-18 11:15 ` Thierry Reding
2017-01-19 14:32 ` Andy Shevchenko
2017-01-20 10:48 ` Thierry Reding
2017-01-05 8:09 ` [PATCH v2 0/4] pwm: lpss: clean up series Ilkka Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118111109.GO18989@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ilkka.koskinen@intel.com \
--cc=linux-pwm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).