From: Ilkka Koskinen <ilkka.koskinen@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org
Subject: Re: [PATCH REGRESSION-FIX resend] pwm: lpss: Set enable-bit before waiting for update-bit
Date: Mon, 27 Mar 2017 15:14:59 -0700 [thread overview]
Message-ID: <20170327221459.GA105573@kammari> (raw)
In-Reply-To: <1490531124.708.1.camel@linux.intel.com>
Hi,
On Sun, Mar 26, 2017 at 03:25:24PM +0300, Andy Shevchenko wrote:
> On Sat, 2017-03-25 at 15:06 +0100, Hans de Goede wrote:
> > Hi Andy, Thierry,
> >
> > This patch fixes a regression with the pwm-lpss driver in 4.11,
> > where it once turned off will not turn back on again on some
> > machines. Yet it has been silent around this patch for some
> > time now. Can you please review this and get it queued as a fix
> > for 4.11 ?
> >
Sorry, my bad. I thought I replied to this but obviously didn't.
> Hans, please, give me and Ilkka time to test this. It might appear that
> this fix breaks other platforms and we might need to introduce a quirk
> based on PCI ID. (Hope not)
While the patch seems ok, I have the same concern.
> P.S. I will try to allocate time next week soonish for that.
>
> Ilkka, can you do some tests on your side?
Unfortunately, I don't have a suitable device anymore as I changed the
team. However, I have asked a colleague to test the patch on BXT. He's
planning to do that this week.
Br, Ilkka
next prev parent reply other threads:[~2017-03-27 22:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-25 14:06 [PATCH REGRESSION-FIX resend] pwm: lpss: Set enable-bit before waiting for update-bit Hans de Goede
2017-03-25 14:06 ` [PATCH v2 resend] pwm: lpss: Set enable-bit before waiting for update-bit to go low Hans de Goede
2017-03-26 12:25 ` [PATCH REGRESSION-FIX resend] pwm: lpss: Set enable-bit before waiting for update-bit Andy Shevchenko
2017-03-26 14:44 ` Hans de Goede
2017-03-27 22:14 ` Ilkka Koskinen [this message]
2017-03-28 14:45 ` Andy Shevchenko
2017-03-28 17:20 ` Hans de Goede
2017-03-28 17:28 ` Andy Shevchenko
2017-03-28 17:33 ` Andy Shevchenko
2017-03-28 19:16 ` Hans de Goede
2017-03-29 11:24 ` Andy Shevchenko
2017-03-29 12:42 ` Hans de Goede
2017-03-29 17:41 ` Andy Shevchenko
2017-03-29 18:25 ` Hans de Goede
2017-03-31 20:07 ` Andy Shevchenko
2017-03-31 20:52 ` Hans de Goede
2017-04-03 14:22 ` Andy Shevchenko
2017-04-03 14:32 ` Hans de Goede
2017-04-04 16:20 ` Andy Shevchenko
2017-04-04 17:02 ` Hans de Goede
2017-04-04 17:23 ` Andy Shevchenko
2017-03-29 4:50 ` Ilkka Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327221459.GA105573@kammari \
--to=ilkka.koskinen@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox