From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Sven Van Asbroeck <thesven73@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Thierry Reding <thierry.reding@gmail.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
clemens.gruber@pqgruber.com,
Sven Van Asbroeck <TheSven73@googlemail.com>
Subject: Re: [PATCH v4 1/1] pwm: pca9685: fix gpio-only operation.
Date: Wed, 19 Apr 2017 23:24:33 +0300 [thread overview]
Message-ID: <20170419202433.GH2619@lahna.fi.intel.com> (raw)
In-Reply-To: <CAGngYiWj1jBsgYAL31Qb2Ne+Te34vpjWD14xbV+u9vRS0i8kkQ@mail.gmail.com>
On Tue, Apr 18, 2017 at 11:52:49AM -0400, Sven Van Asbroeck wrote:
> > __maybe_unused and remove ugly #ifdef:ery.
>
> If this works on non- CONFIG_PM systems, I'm all for it !
> Grepping the drivers/ directory, I see that some drivers use
> #ifdef CONFIG_PM, some use __maybe_unused for runtime_pm.
>
> Mika and Thierry, thoughts ?
I actually prefer CONFIG_PM here but up to Thierry to decide, I guess.
next prev parent reply other threads:[~2017-04-19 20:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 12:58 [PATCH v4 0/1] pwm: pca9685: fix gpio-only operation Sven Van Asbroeck
2017-04-13 12:58 ` [PATCH v4 1/1] " Sven Van Asbroeck
2017-04-13 15:34 ` Thierry Reding
2017-04-18 9:14 ` Andy Shevchenko
2017-04-18 15:52 ` Sven Van Asbroeck
2017-04-19 20:24 ` Mika Westerberg [this message]
2017-04-20 7:29 ` Andy Shevchenko
2017-04-20 14:12 ` Sven Van Asbroeck
2017-04-20 15:07 ` Andy Shevchenko
2017-04-20 15:50 ` Sven Van Asbroeck
2017-04-20 16:13 ` Andy Shevchenko
2017-04-20 15:55 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170419202433.GH2619@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=TheSven73@googlemail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=clemens.gruber@pqgruber.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=thesven73@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).