From: Thierry Reding <thierry.reding@gmail.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>
Subject: Re: [PATCH RFT] pwm: stmpe: Fix wrong register offset for hwpwm=2 case
Date: Fri, 24 Nov 2017 11:42:44 +0100 [thread overview]
Message-ID: <20171124104244.GA3792@ulmo> (raw)
In-Reply-To: <CAFRkauBhALFxedJ-4nBXpjBF9Sd-NW9bQrgwtHUbYjQ3yZGTCw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1223 bytes --]
On Fri, Nov 24, 2017 at 05:10:14PM +0800, Axel Lin wrote:
> 2017-11-09 16:45 GMT+08:00 Linus Walleij <linus.walleij@linaro.org>:
> > On Tue, Nov 7, 2017 at 6:18 AM, Axel Lin <axel.lin@ingics.com> wrote:
> >
> >> Fix trivial copy/paste bug.
> >>
> >> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> >> ---
> >> Hi Linus,
> >> I don't have this h/w to test.
> >> Appreciate if you can review and test this patch.
> >
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Hi Thierry,
> Seems this one is still not apply. Should I resend?
No need to resend, I can see it in patchwork. I'm not exactly sure what
happened, but it looks like this may have just missed the cut-off point
for v4.15-rc1. Is this a serious bug? Do you want it to go into v4.15?
By the looks of it this has been wrong since forever (no changes since
the original patch adding the driver), so I'm wondering if anybody has
ever used this third PWM at all.
I'm fine either way. If this is something that's creating problems, let
me know and I'll queue it for v4.15-rc2. If so, you may want it to be
backported to stable kernel, in which case:
Fixes: ef1f09eca74a ("pwm: Add a driver for the STMPE PWM")
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-11-24 10:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 5:18 [PATCH RFT] pwm: stmpe: Fix wrong register offset for hwpwm=2 case Axel Lin
2017-11-09 8:45 ` Linus Walleij
2017-11-24 9:10 ` Axel Lin
2017-11-24 10:42 ` Thierry Reding [this message]
2017-12-05 8:33 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171124104244.GA3792@ulmo \
--to=thierry.reding@gmail.com \
--cc=axel.lin@ingics.com \
--cc=linus.walleij@linaro.org \
--cc=linux-pwm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).