[PATCH RFT] pwm: stmpe: Fix wrong register offset for hwpwm=2 case

[PATCH RFT] pwm: stmpe: Fix wrong register offset for hwpwm=2 case

[Axel Lin]

Fix trivial copy/paste bug.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi Linus,
I don't have this h/w to test.
Appreciate if you can review and test this patch.

Thanks,
Axel
 drivers/pwm/pwm-stmpe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pwm/pwm-stmpe.c b/drivers/pwm/pwm-stmpe.c
index e464582a390a..3439f1e902cb 100644
--- a/drivers/pwm/pwm-stmpe.c
+++ b/drivers/pwm/pwm-stmpe.c
@@ -145,7 +145,7 @@ static int stmpe_24xx_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
 		break;
 
 	case 2:
-		offset = STMPE24XX_PWMIC1;
+		offset = STMPE24XX_PWMIC2;
 		break;
 
 	default:
-- 
2.11.0

Re: [PATCH RFT] pwm: stmpe: Fix wrong register offset for hwpwm=2 case

[Linus Walleij]

On Tue, Nov 7, 2017 at 6:18 AM, Axel Lin <axel.lin@ingics.com> wrote:

> Fix trivial copy/paste bug.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Hi Linus,
> I don't have this h/w to test.
> Appreciate if you can review and test this patch.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

This is an obvious copy/paste bug indeed.

Yours,
Linus Walleij

Re: [PATCH RFT] pwm: stmpe: Fix wrong register offset for hwpwm=2 case

[Axel Lin]

2017-11-09 16:45 GMT+08:00 Linus Walleij <linus.walleij@linaro.org>:
> On Tue, Nov 7, 2017 at 6:18 AM, Axel Lin <axel.lin@ingics.com> wrote:
>
>> Fix trivial copy/paste bug.
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>> ---
>> Hi Linus,
>> I don't have this h/w to test.
>> Appreciate if you can review and test this patch.
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Hi Thierry,
Seems this one is still not apply. Should I resend?

Thanks,
Axel

Re: [PATCH RFT] pwm: stmpe: Fix wrong register offset for hwpwm=2 case

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1223 bytes --]

On Fri, Nov 24, 2017 at 05:10:14PM +0800, Axel Lin wrote:
> 2017-11-09 16:45 GMT+08:00 Linus Walleij <linus.walleij@linaro.org>:
> > On Tue, Nov 7, 2017 at 6:18 AM, Axel Lin <axel.lin@ingics.com> wrote:
> >
> >> Fix trivial copy/paste bug.
> >>
> >> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> >> ---
> >> Hi Linus,
> >> I don't have this h/w to test.
> >> Appreciate if you can review and test this patch.
> >
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Hi Thierry,
> Seems this one is still not apply. Should I resend?

No need to resend, I can see it in patchwork. I'm not exactly sure what
happened, but it looks like this may have just missed the cut-off point
for v4.15-rc1. Is this a serious bug? Do you want it to go into v4.15?
By the looks of it this has been wrong since forever (no changes since
the original patch adding the driver), so I'm wondering if anybody has
ever used this third PWM at all.

I'm fine either way. If this is something that's creating problems, let
me know and I'll queue it for v4.15-rc2. If so, you may want it to be
backported to stable kernel, in which case:

Fixes: ef1f09eca74a ("pwm: Add a driver for the STMPE PWM")

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH RFT] pwm: stmpe: Fix wrong register offset for hwpwm=2 case

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

On Tue, Nov 07, 2017 at 01:18:53PM +0800, Axel Lin wrote:
> Fix trivial copy/paste bug.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Hi Linus,
> I don't have this h/w to test.
> Appreciate if you can review and test this patch.
> 
> Thanks,
> Axel
>  drivers/pwm/pwm-stmpe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied this and added:

	Fixes: ef1f09eca74a ("pwm: Add a driver for the STMPE PWM")

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]