From: Ladislav Michl <ladis@linux-mips.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Keerthy <j-keerthy@ti.com>,
tony@atomide.com, aaro.koskinen@iki.fi, thierry.reding@gmail.com,
t-kristo@ti.com, linux@armlinux.org.uk, grygorii.strashko@ti.com,
robh+dt@kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org,
sebastian.reichel@collabora.co.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/8] arm: OMAP: Move dmtimer driver out of plat-omap to drivers under clocksource
Date: Fri, 8 Dec 2017 20:19:59 +0100 [thread overview]
Message-ID: <20171208191959.GA5801@lenoch> (raw)
In-Reply-To: <a2f06a16-2468-6b09-171a-ad96e39af3eb@linaro.org>
On Fri, Dec 08, 2017 at 06:50:32PM +0100, Daniel Lezcano wrote:
> On 08/12/2017 18:20, Ladislav Michl wrote:
> > Daniel,
> >
> > On Thu, Dec 07, 2017 at 11:54:27AM +0100, Daniel Lezcano wrote:
> >> On 01/12/2017 06:16, Keerthy wrote:
> >>> Move the dmtimer driver out of plat-omap to clocksource.
> >>> So that non-omap devices also could use this.
> >>>
> >>> No Code changes done to the driver file.
> >>>
> >>> Signed-off-by: Keerthy <j-keerthy@ti.com>
> >>> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> >>> ---
> >>>
> >>> Changes in v3:
> >>>
> >>> * Added Sebastian's Reviewed-by.
> >>>
> >>> Changes in v2:
> >>>
> >>> * No code changes in this v2 version. Only enhanced patch
> >>> statistics for renames.
> >>>
> >>> arch/arm/plat-omap/Kconfig | 6 ------
> >>> arch/arm/plat-omap/Makefile | 1 -
> >>> drivers/clocksource/Kconfig | 6 ++++++
> >>> drivers/clocksource/Makefile | 1 +
> >>> {arch/arm/plat-omap => drivers/clocksource}/dmtimer.c | 0
> >>> 5 files changed, 7 insertions(+), 7 deletions(-)
> >>> rename {arch/arm/plat-omap => drivers/clocksource}/dmtimer.c (100%)
> >>
> >> Take the opportunity to rename it timer-dm.c
> >
> > seems the drivers/clocksource subdirectory contains what its name state.
>
> Yes, clocksource, clockevent.
>
> > However OMAP dual mode timers have also event capture capability, which
> > I'd like to use to measure pulse/space width and pass measured values
> > to IR protocol decoders.
> > Do you have any idea how to split code, so that event capture capability
> > could be used by other drivers?
> Not 100% sure but could be drivers/pwm, using the capture API.
I hoped for another answer as pwm_capture is blocking operation while
something event (interrupt) driven would be more usefull.
But that's for different debate, so I'll prepare quick and dirty patch
to start with.
Thank you,
ladis
next prev parent reply other threads:[~2017-12-08 19:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 5:16 [PATCH v4 0/8] omap: dmtimer: Move driver out of plat-omap Keerthy
2017-12-01 5:16 ` [PATCH v4 1/8] clocksource: dmtimer: Remove all the exports Keerthy
2017-12-01 5:16 ` [PATCH v4 2/8] arm: omap: timer: Wrap the inline functions under OMAP2PLUS define Keerthy
2017-12-01 5:16 ` [PATCH v4 3/8] arm: omap: Move dmtimer.h out of plat-omap Keerthy
2017-12-01 5:16 ` [PATCH v4 4/8] arm: OMAP: Move dmtimer driver out of plat-omap to drivers under clocksource Keerthy
2017-12-07 10:54 ` Daniel Lezcano
2017-12-08 3:55 ` Keerthy
2017-12-08 14:31 ` Keerthy
2017-12-08 17:20 ` Ladislav Michl
2017-12-08 17:50 ` Daniel Lezcano
2017-12-08 19:19 ` Ladislav Michl [this message]
2017-12-01 5:16 ` [PATCH v4 5/8] dmtimer: Add timer ops to the platform data structure Keerthy
2017-12-01 5:16 ` [PATCH v4 6/8] clocksource: dmtimer: Populate the timer ops to the pdata Keerthy
2017-12-01 5:16 ` [PATCH v4 7/8] pwm: pwm-omap-dmtimer: Adapt driver to utilize dmtimer pdata ops Keerthy
2017-12-01 5:16 ` [PATCH v4 8/8] arm: omap: pdata-quirks: Remove unused timer pdata Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208191959.GA5801@lenoch \
--to=ladis@linux-mips.org \
--cc=aaro.koskinen@iki.fi \
--cc=daniel.lezcano@linaro.org \
--cc=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
--cc=t-kristo@ti.com \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).