From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-sunxi@googlegroups.com, Chen-Yu Tsai <wens@csie.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/5] pwm: sun4i: Introduce (optional) reset support
Date: Wed, 7 Mar 2018 08:45:16 +0100 [thread overview]
Message-ID: <20180307074516.dbak7ztkua4p7mr5@flea.lan> (raw)
In-Reply-To: <20180307020719.6675-4-andre.przywara@arm.com>
[-- Attachment #1.1: Type: text/plain, Size: 675 bytes --]
On Wed, Mar 07, 2018 at 02:07:17AM +0000, Andre Przywara wrote:
> While the PWM IP in the Allwinner H6 SoC is fully compatible to those
> used in older SoCs (H3, A64), it features a dedicated reset line which
> needs to be de-asserted.
> Add support for an optional "resets" DT property in our pwm-sun4i probe
> routine, and assert and de-assert the reset line, where needed.
> This allows to enable PWM support on the H6.
This isn't optional then. It's mandatory on the H6, and unneeded on
everything else. This is what we should have.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-03-07 7:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 2:07 [PATCH 0/5] drivers: pwm: sun4i: Improve support for A64 and H6 SoCs Andre Przywara
[not found] ` <20180307020719.6675-1-andre.przywara-5wv7dgnIgG8@public.gmane.org>
2018-03-07 2:07 ` [PATCH 1/5] pwm: sun4i: drop unused .has_rdy member Andre Przywara
2018-03-07 7:40 ` Maxime Ripard
2018-03-07 2:07 ` [PATCH 2/5] pwm: sun4i: simplify controller mapping Andre Przywara
2018-03-07 7:44 ` Maxime Ripard
2018-03-07 2:07 ` [PATCH 3/5] pwm: sun4i: Introduce (optional) reset support Andre Przywara
2018-03-07 7:45 ` Maxime Ripard [this message]
[not found] ` <20180307074516.dbak7ztkua4p7mr5-ZC1Zs529Oq4@public.gmane.org>
2018-03-13 14:05 ` Andre Przywara
2018-03-13 15:32 ` Maxime Ripard
2018-03-07 2:07 ` [PATCH 4/5] dt-bindings: pwm: sunxi: add new compatible strings Andre Przywara
[not found] ` <20180307020719.6675-5-andre.przywara-5wv7dgnIgG8@public.gmane.org>
2018-03-08 2:08 ` Rob Herring
2018-03-08 9:09 ` Andre Przywara
[not found] ` <9431a141-8b9c-9743-0907-8f0720df34a2-5wv7dgnIgG8@public.gmane.org>
2018-03-08 14:37 ` Rob Herring
[not found] ` <CAL_Jsq+e8uRm0gi1dn3Ln-b37SC9WGw5aWPaBKoRA2vi-==j6A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-03-08 15:27 ` Andre Przywara
2018-03-07 2:07 ` [PATCH 5/5] dts: sunxi: A64: Add PWM controllers Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307074516.dbak7ztkua4p7mr5@flea.lan \
--to=maxime.ripard@bootlin.com \
--cc=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=thierry.reding@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox