Re: [PATCH v3 RESEND] pwm: imx: Let PWM be active during suspend

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]

On Tue, Jan 02, 2018 at 11:01:59AM -0200, Fabio Estevam wrote:
> On a imx6q-cubox-i board, which has an LED driven by PWM, when the system
> goes into suspend the PWM block is disabled by default, then the PWM pin
> goes to logic level zero and turn on the LED during suspend, which is not
> really the behaviour we want to see.
> 
> By keeping the PWM enabled during suspend via STOPEN bit, the pwm-leds
> driver sets the brightness to zero in suspend and then the LED is
> turned off as expected.
> 
> So always set the STOPEN to fix the PWM behaviour in suspend.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> Hi Thierry,
> 
> Resending it in the hope we can still get this in for 4.16.
> 
> Please not that STOPEN is also unconditionally set in vendor's kernel:
> http://git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/tree/arch/arm/plat-mxc/pwm.c?h=imx_3.0.35_4.1.0#n106
> 
>  drivers/pwm/pwm-imx.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied, thanks.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]