From: Thierry Reding <thierry.reding@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: linux-pwm@vger.kernel.org, Fabio Estevam <fabio.estevam@nxp.com>
Subject: Re: [PATCH] pwm: imx: Switch to SPDX identifier
Date: Wed, 6 Jun 2018 11:09:46 +0200 [thread overview]
Message-ID: <20180606090946.GG11810@ulmo> (raw)
In-Reply-To: <1526830815-15644-1-git-send-email-festevam@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]
On Sun, May 20, 2018 at 12:40:15PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Adopt the SPDX license identifier headers to ease license compliance
> management.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> drivers/pwm/pwm-imx.c | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
> index 08cbe81..6ddd6fd 100644
> --- a/drivers/pwm/pwm-imx.c
> +++ b/drivers/pwm/pwm-imx.c
> @@ -1,12 +1,8 @@
> -/*
> - * simple driver for PWM (Pulse Width Modulator) controller
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation.
> - *
> - * Derived from pxa PWM driver by eric miao <eric.miao@marvell.com>
> - */
> +// SPDX-License-Identifier: GPL-2.0
> +//
> +// simple driver for PWM (Pulse Width Modulator) controller
> +//
> +// Derived from pxa PWM driver by eric miao <eric.miao@marvell.com>
Why do you replace the complete comment by C++ style? I thought only the
SPDX identifier was required to be in that style.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-06-06 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-20 15:40 [PATCH] pwm: imx: Switch to SPDX identifier Fabio Estevam
2018-06-06 9:09 ` Thierry Reding [this message]
2018-06-06 11:38 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180606090946.GG11810@ulmo \
--to=thierry.reding@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=linux-pwm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox