From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Vladimir Zapolskiy <vz@mleia.com>
Cc: linux-pwm@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH] pwm: lpc18xx-sct: don't reconfigure PWM in .request and .free
Date: Fri, 16 Nov 2018 10:48:02 +0100 [thread overview]
Message-ID: <20181116094802.5qpaygab5epnmwp5@pengutronix.de> (raw)
In-Reply-To: <1391bbe1-75b5-c86e-ed3a-1e1afb393917@mleia.com>
On Fri, Nov 16, 2018 at 11:22:49AM +0200, Vladimir Zapolskiy wrote:
> Hello Uwe,
>
> On 11/16/2018 08:52 AM, Uwe Kleine-König wrote:
> > Regarding the .request case: The consumer might be interested in taking
> > over the configured state from the boot loader. So the initially
> > configured state should be retained.
> >
> > For the free case the PWM consumer is responsible to disable the PWM
> > before calling pwm_release and there are three subcases to consider:
> >
>
> the changes are fine per se, but please split them into two.
>
> Probably pwm_disable() misusage began spreading from commit 54b2a999a1675.
I see little benefit, but if that's the only problem I can split.
Note that the behaviours of .request and .free are not unrelated.
Currently because .free sets a duty cycle of 0 we have
pwm_get_duty_cycle always return 0 in .request.
Waiting on what Thierry thinks.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2018-11-16 9:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 19:45 is pwm_put supposed to stop a PWM? Uwe Kleine-König
2018-10-29 11:48 ` Thierry Reding
2018-11-03 14:49 ` Uwe Kleine-König
2018-11-14 9:30 ` Uwe Kleine-König
2018-11-14 11:50 ` Thierry Reding
2018-11-15 8:42 ` Uwe Kleine-König
2018-11-15 15:43 ` Thierry Reding
2018-11-15 20:46 ` Uwe Kleine-König
2018-11-16 6:52 ` [PATCH] pwm: lpc18xx-sct: don't reconfigure PWM in .request and .free Uwe Kleine-König
2018-11-16 7:02 ` Uwe Kleine-König
2018-11-16 9:22 ` Vladimir Zapolskiy
2018-11-16 9:48 ` Uwe Kleine-König [this message]
2018-11-16 10:01 ` Thierry Reding
2018-11-16 10:45 ` Uwe Kleine-König
2018-11-16 10:05 ` Thierry Reding
2018-11-19 19:55 ` Uwe Kleine-König
2018-11-20 15:42 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116094802.5qpaygab5epnmwp5@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox