Re: [PATCH] PWM: drop legacy wrapper for changing polarity

Uwe Kleine-König
2018-12-12T10:59:02Z

Hello Thierry,

On Wed, Dec 12, 2018 at 11:25:47AM +0100, Thierry Reding wrote:
> I certainly wouldn't mind a little help. Reviewing patches will
> definitely help move things along.

I already did. Apart from my patch series noted before:

- series for pwm-imx starting with
"pwm: imx: remove if block where the condition is always wrong"
- "pwm: don't use memcmp to compare struct state variables"
- "pwm: drop per-chip dbg_show callback"

I think the following patches are ready for application:

- [v3] pwm: kconfig: enable kona pwm to be built for cygnus arch
- [13/17] pwm: bcm2835: Switch to SPDX identifier

As I only recently subscribed to the linux-pwm list I don't have the
older patches listed on
https://patchwork.ozlabs.org/project/linux-pwm/list/ in my inbox. Just
grabbed Michal's imx get_state series from there and replied.

Other than that feedback to my RFC doc patch would be great. One thing I
didn't mention there is: Is pwm_disable supposed to wait for the current
period to end? I'd say yes (even though it might make sense to have the
possibility to stop immediately in some cases).