From: Dan Carpenter <dan.carpenter@oracle.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Anson Huang <anson.huang@nxp.com>
Cc: linux-pwm@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] pwm: imx: Signedness bug in imx_pwm_get_state()
Date: Wed, 9 Jan 2019 11:27:47 +0300 [thread overview]
Message-ID: <20190109082747.GA5476@kadam> (raw)
"ret" only holds zero and negative error codes. It needs to be signed
for the error handling to work.
Fixes: 9f4c8f9607c3 ("pwm: imx: Add ipg clock operation")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/pwm/pwm-imx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
index 55a3a363d5be..b8452abe2392 100644
--- a/drivers/pwm/pwm-imx.c
+++ b/drivers/pwm/pwm-imx.c
@@ -128,8 +128,9 @@ static void imx_pwm_get_state(struct pwm_chip *chip,
struct pwm_device *pwm, struct pwm_state *state)
{
struct imx_chip *imx = to_imx_chip(chip);
- u32 period, prescaler, pwm_clk, ret, val;
+ u32 period, prescaler, pwm_clk, val;
u64 tmp;
+ int ret;
ret = imx_pwm_clk_prepare_enable(chip);
if (ret < 0)
--
2.17.1
next reply other threads:[~2019-01-09 8:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 8:27 Dan Carpenter [this message]
2019-01-10 10:18 ` [PATCH] pwm: imx: Signedness bug in imx_pwm_get_state() Uwe Kleine-König
2019-01-10 11:08 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109082747.GA5476@kadam \
--to=dan.carpenter@oracle.com \
--cc=anson.huang@nxp.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).