Re: [PATCH 2/4] pwm: drop per-chip dbg_show callback

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]

On Mon, Jan 07, 2019 at 08:49:39PM +0100, Uwe Kleine-König wrote:
> This callback was introduced in commit 62099abf67a2 ("pwm: Add debugfs
> interface") in 2012 and up to now there is not a single user. So drop this
> unused code.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/pwm/core.c  | 5 +----
>  include/linux/pwm.h | 3 ---
>  2 files changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
> index 253a459fe0d8..3149204567f3 100644
> --- a/drivers/pwm/core.c
> +++ b/drivers/pwm/core.c
> @@ -1036,10 +1036,7 @@ static int pwm_seq_show(struct seq_file *s, void *v)
>  		   dev_name(chip->dev), chip->npwm,
>  		   (chip->npwm != 1) ? "s" : "");
>  
> -	if (chip->ops->dbg_show)
> -		chip->ops->dbg_show(chip, s);
> -	else
> -		pwm_dbg_show(chip, s);
> +	pwm_dbg_show(chip, s);
>  
>  	return 0;
>  }
> diff --git a/include/linux/pwm.h b/include/linux/pwm.h
> index d5199b507d79..2730725f6d88 100644
> --- a/include/linux/pwm.h
> +++ b/include/linux/pwm.h
> @@ -272,9 +272,6 @@ struct pwm_ops {
>  		     struct pwm_state *state);
>  	void (*get_state)(struct pwm_chip *chip, struct pwm_device *pwm,
>  			  struct pwm_state *state);
> -#ifdef CONFIG_DEBUG_FS
> -	void (*dbg_show)(struct pwm_chip *chip, struct seq_file *s);
> -#endif

I edited the patch to remove the kerneldoc for this function as well.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]