From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm1-f66.google.com ([209.85.128.66]:37192 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727780AbfAJLI2 (ORCPT ); Thu, 10 Jan 2019 06:08:28 -0500 Date: Thu, 10 Jan 2019 12:08:22 +0100 From: Thierry Reding Message-ID: <20190110110822.GA17719@ulmo> References: <20190109082747.GA5476@kadam> <20190110101818.msnvtpw6yczpeybc@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xHFwDpU9dbj6ez1V" Content-Disposition: inline In-Reply-To: <20190110101818.msnvtpw6yczpeybc@pengutronix.de> Sender: linux-pwm-owner@vger.kernel.org List-ID: Subject: Re: [PATCH] pwm: imx: Signedness bug in imx_pwm_get_state() To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Dan Carpenter , Anson Huang , linux-pwm@vger.kernel.org, kernel-janitors@vger.kernel.org --xHFwDpU9dbj6ez1V Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 10, 2019 at 11:18:18AM +0100, Uwe Kleine-K=C3=B6nig wrote: > On Wed, Jan 09, 2019 at 11:27:47AM +0300, Dan Carpenter wrote: > > "ret" only holds zero and negative error codes. It needs to be signed > > for the error handling to work. > >=20 > > Fixes: 9f4c8f9607c3 ("pwm: imx: Add ipg clock operation") > > Signed-off-by: Dan Carpenter >=20 > I would have expected a compiler warning but at least for me there is > none emitted. Hmm. >=20 > Reviewed-by: Uwe Kleine-K=C3=B6nig >=20 > @Thierry: Given that this is a fix I assume you want to apply this patch > before my pwm-imx series (which is cleanup only). This will conflict for > sure with my driver splitting patch. Please tell me if/when I should > resend my series rebased on top of this patch. It's fine, I manually applied this on top of the driver split patch. Thierry --xHFwDpU9dbj6ez1V Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlw3J6YACgkQ3SOs138+ s6FpsBAArtM1IvBCMK3/obcbugb4lMs4wzGpDSU1yNGMGFb2RSvZD1/fjmHL8B0C k/jhhZuJser/ebVO9lW29NqC8DqdEhj7J6qBhTAlZoq/II6nyuhcrajjVA3SqXpP nc2kTmT50XyZDL4Q61l0qJszGEBBsESX8fvgVD5YtfbLAQPXzotcl+5w4LLpkd+d 5/5tEbJhEQyV3wuLgedxq6HenW93QhP1C8a708TnB15GWmhxixiKNwueIGxSdeeh tPiF7ISNyAz8i9lcXFX1qV3x++MU134GGClvD5YaxJarYmMIWIDFn9yWskaxjiPt sV1s5KCa+kSgOrcAwczziZrdEteILo1RCjbapCfXW9BLegoVNHy0kyaSQzULhnjd jWbSEacaICGMGJqjHwFr+p0KEBc9Nnbt89J4lHsQkOdcaZ/EcapEJaczME02M7Uw L7pPWex2D0G/GPTKKtjrTCxJHzcM5DmMNuzIxC9m+5k+OEdqwWjLReSZ73agfSl4 SfQM5OD4PUXBph/8hcdaBHNZcj44BTYI3DlKR+qlrGOPU+xajpJXoHG+Om85nSdt ss/eaFSpD2943eJDBMKc2LjXUT3iAapwpYxHasCaQl3BKron0suwC1D3cHF+UIPK 7Yuz6hGD4/TZvdDpG70UB0XTd30viRZI1RECQEVYf6lc2+SG0h4= =qO9H -----END PGP SIGNATURE----- --xHFwDpU9dbj6ez1V--