From: Thierry Reding <thierry.reding@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-pwm@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>,
kernel@pengutronix.de
Subject: Re: [PATCH] pwm: imx27: only enable the clocks once in .get_state
Date: Mon, 4 Mar 2019 12:23:18 +0100 [thread overview]
Message-ID: <20190304112318.GA7617@ulmo> (raw)
In-Reply-To: <20190110193353.20767-1-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 554 bytes --]
On Thu, Jan 10, 2019 at 08:33:53PM +0100, Uwe Kleine-König wrote:
> Currently the function pwm_imx27_get_state() of enables the clocks once
> unconditionally at the start, a second time if the PWM is enabled and
> disables unconditionally at the end.
>
> Simplify that to enable once at the start and disable conditionally at
> the end.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/pwm/pwm-imx27.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-03-04 11:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 19:33 [PATCH] pwm: imx27: only enable the clocks once in .get_state Uwe Kleine-König
2019-03-04 11:23 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304112318.GA7617@ulmo \
--to=thierry.reding@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-pwm@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).