[PATCH] pwm: atmel: Remove useless symbolic definitions

[PATCH] pwm: atmel: Remove useless symbolic definitions

[Thierry Reding]

The values that these symbols define are only assigned to the per-SoC
structure where the context is clear, so there's no need for the extra
symbolic name.

Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
---
 drivers/pwm/pwm-atmel.c | 20 ++++++--------------
 1 file changed, 6 insertions(+), 14 deletions(-)

diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c
index b1473ed55110..a9fd6f0d408c 100644
--- a/drivers/pwm/pwm-atmel.c
+++ b/drivers/pwm/pwm-atmel.c
@@ -48,14 +48,6 @@
 #define PWMV2_CPRD		0x0C
 #define PWMV2_CPRDUPD		0x10
 
-/* Max values for period and prescaler */
-
-/* Only the LSB 16 bits are significant. */
-#define PWM_MAXV1_PRD		0xFFFF
-/* All 32 bits are significant. */
-#define PWM_MAXV2_PRD		0xFFFFFFFF
-#define PRD_MAXV1_PRES		10
-
 struct atmel_pwm_registers {
 	u8 period;
 	u8 period_upd;
@@ -294,8 +286,8 @@ static const struct atmel_pwm_data atmel_sam9rl_pwm_data = {
 	},
 	.cfg = {
 		/* 16 bits to keep period and duty. */
-		.max_period	= PWM_MAXV1_PRD,
-		.max_pres	= PRD_MAXV1_PRES,
+		.max_period	= 0xffff,
+		.max_pres	= 10,
 	},
 };
 
@@ -308,8 +300,8 @@ static const struct atmel_pwm_data atmel_sama5_pwm_data = {
 	},
 	.cfg = {
 		/* 16 bits to keep period and duty. */
-		.max_period	= PWM_MAXV1_PRD,
-		.max_pres	= PRD_MAXV1_PRES,
+		.max_period	= 0xffff,
+		.max_pres	= 10,
 	},
 };
 
@@ -322,8 +314,8 @@ static const struct atmel_pwm_data mchp_sam9x60_pwm_data = {
 	},
 	.cfg = {
 		/* 32 bits to keep period and duty. */
-		.max_period	= PWM_MAXV2_PRD,
-		.max_pres	= PRD_MAXV1_PRES,
+		.max_period	= 0xffffffff,
+		.max_pres	= 10,
 	},
 };
 
-- 
2.20.1

Re: [PATCH] pwm: atmel: Remove useless symbolic definitions

[Claudiu.Beznea]

On 04.03.2019 13:12, Thierry Reding wrote:
> The values that these symbols define are only assigned to the per-SoC
> structure where the context is clear, so there's no need for the extra
> symbolic name.
> 
> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
> ---
>  drivers/pwm/pwm-atmel.c | 20 ++++++--------------
>  1 file changed, 6 insertions(+), 14 deletions(-)

Acked-by: Claudiu Beznea <claudiu.beznea@microchip.com>

Re: [PATCH] pwm: atmel: Remove useless symbolic definitions

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 431 bytes --]

On Mon, Mar 04, 2019 at 12:12:42PM +0100, Thierry Reding wrote:
> The values that these symbols define are only assigned to the per-SoC
> structure where the context is clear, so there's no need for the extra
> symbolic name.
> 
> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
> ---
>  drivers/pwm/pwm-atmel.c | 20 ++++++--------------
>  1 file changed, 6 insertions(+), 14 deletions(-)

Applied.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]