From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v2 1/3] pwm: rockchip: Don't update the state for the caller of pwm_apply_state() Date: Thu, 2 May 2019 09:16:38 +0200 Message-ID: <20190502091638.0f5a40b0@collabora.com> References: <20190312214605.10223-1-u.kleine-koenig@pengutronix.de> <20190312214605.10223-2-u.kleine-koenig@pengutronix.de> <1707507.TOMHpQGrZ7@phil> <20190408143914.uucb5dwafq3cnsmk@pengutronix.de> <20190429065613.n52uwgys5eugmssd@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Doug Anderson Cc: linux-pwm , Heiko Stuebner , Maxime Ripard , Brian Norris , "open list:ARM/Rockchip SoC..." , Chen-Yu Tsai , Thierry Reding , Sascha Hauer , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= List-Id: linux-pwm@vger.kernel.org T24gTW9uLCAyOSBBcHIgMjAxOSAxMTowNDoyMCAtMDcwMApEb3VnIEFuZGVyc29uIDxkaWFuZGVy c0BjaHJvbWl1bS5vcmc+IHdyb3RlOgoKPiBIaSwKPiAKPiBPbiBTdW4sIEFwciAyOCwgMjAxOSBh dCAxMTo1NiBQTSBVd2UgS2xlaW5lLUvDtm5pZwo+IDx1LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9u aXguZGU+IHdyb3RlOgo+ID4KPiA+IE9uIFRodSwgQXByIDE4LCAyMDE5IGF0IDA1OjI3OjA1UE0g LTA3MDAsIEJyaWFuIE5vcnJpcyB3cm90ZTogIAo+ID4gPiBIaSwKPiA+ID4KPiA+ID4gSSdtIG5v dCBzdXJlIGlmIEknbSBtaXNyZWFkaW5nIHlvdSwgYnV0IEkgdGhvdWdodCBJJ2QgYWRkIGhlcmUg YmVmb3JlCj4gPiA+IHRoaXMgZXhwaXJlcyBvdXQgb2YgbXkgaW5ib3g6Cj4gPiA+Cj4gPiA+IE9u IE1vbiwgQXByIDgsIDIwMTkgYXQgNzozOSBBTSBVd2UgS2xlaW5lLUvDtm5pZwo+ID4gPiA8dS5r bGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPiB3cm90ZTogIAo+ID4gPiA+IE15IGludGVudGlv biBoZXJlIGlzIG1vcmUgdG8gbWFrZSBhbGwgZHJpdmVycyBiZWhhdmUgdGhlIHNhbWUgd2F5IGFu ZAo+ID4gPiA+IGJlY2F1c2Ugb25seSB0d28gZHJpdmVycyB1cGRhdGVkIHRoZSBwd21fc3RhdGUg dGhpcyB3YXMgdGhlIHZhcmlhbnQgSQo+ID4gPiA+IHJlbW92ZWQuICAKPiA+ID4KPiA+ID4gVG8g YmUgY2xlYXIsIHRoaXMgcGF0Y2ggb24gaXRzIG93biBpcyBwcm9iYWJseSBicmVha2luZyB0aGlu Z3MuIEp1c3QKPiA+ID4gYmVjYXVzZSB0aGUgb3RoZXIgZHJpdmVycyBkb24ndCBpbXBsZW1lbnQg dGhlIGRvY3VtZW50ZWQgYmVoYXZpb3IKPiA+ID4gZG9lc24ndCBtZWFuIHlvdSBzaG91bGQgYnJl YWsgdGhpcyBkcml2ZXIuIE1heWJlIHRoZSBvdGhlcnMganVzdAo+ID4gPiBhcmVuJ3QgdXNlZCBp biBwcmVjaXNlIGVub3VnaCBzY2VuYXJpb3Mgd2hlcmUgdGhpcyBtYXR0ZXJzLgo+ID4gPiAgCj4g PiA+ID4gV2hlbiB5b3Ugc2F5IHRoYXQgdGhlIGNhbGxlciBtaWdodCBhY3R1YWxseSBjYXJlIGFi b3V0IHRoZSBleGFjdAo+ID4gPiA+IHBhcmFtZXRlcnMgSSBmdWxseSBhZ3JlZS4gSW4gdGhpcyBj YXNlIGhvd2V2ZXIgdGhlIGNvbnN1bWVyIHNob3VsZCBiZQo+ID4gPiA+IGFibGUgdG8ga25vdyB0 aGUgcmVzdWx0IGJlZm9yZSBhY3R1YWxseSBhcHBseWluZyBpdC4gU28gaWYgeW91IGRvCj4gPiA+ ID4KPiA+ID4gPiAgICAgICAgIHB3bV9hcHBseV9zdGF0ZShwd20sIHsgLnBlcmlvZCA9IDE3LCAu ZHV0eV9jeWNsZSA9IDEyLCAuLi59KQo+ID4gPiA+Cj4gPiA+ID4gYW5kIHRoaXMgcmVzdWx0cyBp biAucGVyaW9kID0gMTAwIGFuZCAuZHV0eV9jeWNsZSA9IDAgdGhlbiBwcm9iYWJseSB0aGUKPiA+ ID4gPiBiYWQgdGhpbmdzIHlvdSB3YW50IHRvIGtub3cgYWJvdXQgYWxyZWFkeSBoYXBwZW5kLiBT byBteSBpZGVhIGlzIGEgbmV3Cj4gPiA+ID4gZnVuY3Rpb24gcHdtX3JvdW5kX3N0YXRlKCkgdGhh dCBkb2VzIHRoZSBhZGFwdGlvbnMgdG8gcHdtX3N0YXRlIHdpdGhvdXQKPiA+ID4gPiBhcHBseWlu ZyBpdCB0byB0aGUgaGFyZHdhcmUuIEFmdGVyIHRoYXQgcHdtX2FwcGx5X3N0YXRlIGNvdWxkIGRv IHRoZQo+ID4gPiA+IGZvbGxvd2luZzoKPiA+ID4gPgo+ID4gPiA+ICAgICAgICAgcnN0YXRlID0g cHdtX3JvdW5kX3N0YXRlKHB3bSwgc3RhdGUpCj4gPiA+ID4gICAgICAgICBwd20uYXBwbHkocHdt LCBzdGF0ZSkKPiA+ID4gPiAgICAgICAgIGdzdGF0ZSA9IHB3bV9nZXRfc3RhdGUocHdtKQo+ID4g PiA+Cj4gPiA+ID4gICAgICAgICBpZiByc3RhdGUgIT0gZ3N0YXRlOgo+ID4gPiA+ICAgICAgICAg ICAgICAgICB3YXJuIGFib3V0IHByb2JsZW1zICAKPiA+ID4KPiA+ID4gRm9yIG91ciBjYXNlICh3 ZSdyZSB1c2luZyB0aGlzIHdpdGggcHdtLXJlZ3VsYXRvciksIEkgZG9uJ3QgcmVjYWxsIFsqXQo+ ID4gPiB3ZSBuZWVkIHRvIGJlIDEwMCUgcHJlY2lzZSBhYm91dCB0aGUgcGVyaW9kLCBidXQgd2Ug ZG8gbmVlZCB0byBiZSBhcwo+ID4gPiBwcmVjaXNlIGFzIHBvc3NpYmxlIHdpdGggdGhlIGR1dHk6 cGVyaW9kIHJhdGlvIC0tIHNvIG9uY2Ugd2UgZ2V0IHRoZQo+ID4gPiAiZmVlZGJhY2siIGZyb20g dGhlIHVuZGVybHlpbmcgUFdNIGRyaXZlciB3aGF0IHRoZSByZWFsIHBlcmlvZCB3aWxsCj4gPiA+ IGJlLCB3ZSBhZGp1c3QgdGhlIGR1dHkgYXBwcm9wcmlhdGVseS4gIAo+ID4KPiA+IEkgYWRtaXQg dGhhdCBJIGRpZG4ndCB1bmRlcnN0b29kIHRoZSB3aG9sZSBzaXR1YXRpb24gYW5kIChzb21lKSB0 aGluZ3MKPiA+IGFyZSB3b3JzZSB3aXRoIG15IHBhdGNoZXMgYXBwbGllZC4gSSBzdGlsbCB0aGlu ayB0aGF0IGNoYW5naW5nIHRoZQo+ID4gY2FsbGVyJ3Mgc3RhdGUgdmFyaWFibGUgaXMgYmFkIGRl c2lnbiwgYnV0IG9mIGNvdXJzZSBwd21fZ2V0X3N0YXRlCj4gPiBzaG91bGQgcmV0dXJuIHRoZSBj dXJyZW50bHkgaW1wbGVtZW50ZWQgY29uZmlndXJhdGlvbi4gIAo+IAo+IFJlZ2FyZGxlc3Mgb2Yg dGhlIHByb3MgYW5kIGNvbnMgb2YgdGhlIGN1cnJlbnQgc2l0dWF0aW9uLCBob3BlZnVsbHkKPiB3 ZSdyZSBpbiBhZ3JlZW1lbnQgdGhhdCB3ZSBzaG91bGRuJ3QgYnJlYWsgZXhpc3RpbmcgdXNlcnM/ ICBJbiBnZW5lcmFsCj4gSSdsbCBwcm9iYWJseSBzdGF5IG91dCBvZiB0aGUgZGViYXRlIGFzIGxv bmcgYXMgd2UgZW5kIHNvbWV3aGVyZSB0aGF0Cj4gcHdtX3JlZ3VsYXRvciBpcyBhYmxlIHRvIHNv bWVob3cga25vdyB0aGUgYWN0dWFsIHN0YXRlIHRoYXQgaXQKPiBwcm9ncmFtbWVkIGludG8gdGhl IGhhcmR3YXJlLgo+IAo+ICtCb3JpcyB0b28gaW4gY2FzZSBoZSBoYXMgYW55IGNvbW1lbnRzLgoK V2VsbCwgdGhlIHB3bV9yb3VuZF9zdGF0ZSgpIGFwcHJvYWNoIHNvdW5kcyBva2F5IHRvIG1lLCB0 aG91Z2ggSSBkb24ndApyZWFsbHkgc2VlIHdoeSBpdCdzIHdyb25nIHRvIGFkanVzdCB0aGUgc3Rh dGUgaW4gcHdtX2FwcGx5X3N0YXRlKCkKKGp1c3QgbGlrZSBjbGtfc2V0X3JhdGUoKSB3aWxsIHJv dW5kIHRoZSByYXRlIGZvciB5b3UgYnkgaW50ZXJuYWxseQpjYWxsaW5nIGNsa19yb3VuZF9yYXRl KCkgYmVmb3JlIGFwcGx5aW5nIHRoZSBjb25maWcpLiBOb3RlIHRoYXQKcHdtX2NvbmZpZygpIGlz IGRvaW5nIGV4YWN0bHkgdGhlIHNhbWU6IGl0IGFkanVzdHMgdGhlIGNvbmZpZyB0byBIVwpjYXBz LCBleGNlcHRzIGluIHRoYXQgY2FzZSB5b3UgZG9uJ3Qga25vdyBpdC4KCkkgZG8gdW5kZXJzdGFu ZCB0aGF0IHNvbWUgdXNlcnMgbWlnaHQgd2FudCB0byBjaGVjayBob3cgdGhlIEhXIHdpbGwKYWRq dXN0IHRoZSBwZXJpb2QvZHV0eSBiZWZvcmUgYXBwbHlpbmcgdGhlIG5ldyBzZXR1cCwgYW5kIGlu IHRoYXQKcmVnYXJkLCBoYXZpbmcgcHdtX3JvdW5kX3JhdGUoKSBpcyBhIGdvb2QgdGhpbmcuIEJ1 dCBpbiBhbnkgY2FzZSwgaXQncwpoYXJkIGZvciB0aGUgdXNlciB0byBkZWNpZGUgaG93IHRvIGFk anVzdCB0aGluZ3MgdG8gZ2V0IHdoYXQgaXQgd2FudHMKKHNob3VsZCBoZSBpbmNyZWFzZS9kZWNy ZWFzZSB0aGUgcGVyaW9kL2R1dHk/KS4KCk15IGltcHJlc3Npb24gaXMgdGhhdCBtb3N0IHVzZXJz IGNhcmUgYWJvdXQgdGhlIGR1dHkvcGVyaW9kIHJhdGlvIHdpdGgKbGl0dGxlIGludGVyZXN0IGlu IGFjY3VyYXRlIHBlcmlvZCBzZXR0aW5ncyAoYXMgbG9uZyBhcyBpdCdzIGNsb3NlCmVub3VnaCB0 byB3aGF0IHRoZXkgZXhwZWN0IG9mIGNvdXJzZSkuIEZvciB0aGUgcm91bmQtdXAvZG93bi9jbG9z ZXN0CmFzcGVjdCwgSSBndWVzcyB0aGF0J3MgYWxzbyBzb21ldGhpbmcgd2UgY2FuIHBhc3MgdG8g dGhlIG5ldyBBUEkuIFNvLApyYXRoZXIgdGhhbiBwYXNzaW5nIGl0IGEgZHV0eSBpbiBucywgbWF5 YmUgd2UgY291bGQgcGFzcyBpdCBhIHJhdGlvCihwZXJjZW50IGlzIHByb2JhYmx5IG5vdCBwcmVj aXNlIGVub3VnaCBmb3Igc29tZSB1c2UgY2FzZXMsIHNvIHdlIGNvdWxkCm1ha2UgaXQgcGVyLW1p bGxpb24pLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K TGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1y b2NrY2hpcAo=