From: Pavel Machek <pavel@ucw.cz>
To: Dan Murphy <dmurphy@ti.com>
Cc: Nikolaus Voss <nikolaus.voss@loewensteinmedical.de>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
Robert Moore <robert.moore@intel.com>,
Erik Schmauss <erik.schmauss@intel.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-acpi@vger.kernel.org, devel@acpica.org,
linux-leds@vger.kernel.org, linux-pwm@vger.kernel.org
Subject: Re: [PATCH 1/3] ACPI: Resolve objects on host-directed table loads
Date: Fri, 31 May 2019 14:23:21 +0200 [thread overview]
Message-ID: <20190531122320.GB3722@amd> (raw)
In-Reply-To: <2944848d-d004-6750-b95d-825b1758ff22@ti.com>
[-- Attachment #1: Type: text/plain, Size: 850 bytes --]
Hi!
> >diff --git a/drivers/acpi/acpica/tbxfload.c b/drivers/acpi/acpica/tbxfload.c
> >index 4f30f06a6f78..61f2d46e52ba 100644
> >--- a/drivers/acpi/acpica/tbxfload.c
> >+++ b/drivers/acpi/acpica/tbxfload.c
> >@@ -297,6 +297,17 @@ acpi_status acpi_load_table(struct acpi_table_header *table)
> > status = acpi_tb_install_and_load_table(ACPI_PTR_TO_PHYSADDR(table),
> > ACPI_TABLE_ORIGIN_EXTERNAL_VIRTUAL,
> > FALSE, &table_index);
> >+
> >+ if (!ACPI_FAILURE(status)) {
> Checkpatch should complain about putting brackets around single statement
> if's.
With multiline statement like that and including comment -- I'd say
keep {'s. It is cleaner this way.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-05-31 12:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 12:18 [PATCH 0/3] PWM framework: add support referencing PWMs from ACPI Nikolaus Voss
2019-05-29 12:18 ` [PATCH 1/3] ACPI: Resolve objects on host-directed table loads Nikolaus Voss
2019-05-30 14:42 ` Dan Murphy
2019-05-31 12:23 ` Pavel Machek [this message]
2019-05-31 12:45 ` Dan Murphy
2019-05-31 12:46 ` Dan Murphy
2019-06-03 9:12 ` Nikolaus Voss
2019-08-14 18:50 ` Andy Shevchenko
2019-08-14 20:27 ` Schmauss, Erik
2019-08-16 11:57 ` Nikolaus Voss
2019-08-30 14:53 ` Shevchenko, Andriy
2019-09-04 7:20 ` Nikolaus Voss
2019-09-06 17:46 ` Shevchenko, Andriy
2019-05-29 12:18 ` [PATCH 2/3] PWM framework: add support referencing PWMs from ACPI Nikolaus Voss
2019-05-30 14:54 ` Dan Murphy
2019-05-31 12:24 ` Pavel Machek
2019-06-03 9:27 ` Nikolaus Voss
2019-05-29 12:18 ` [PATCH 3/3] leds-pwm.c: support ACPI via firmware-node framework Nikolaus Voss
2019-05-30 15:14 ` Dan Murphy
2019-06-03 9:44 ` Nikolaus Voss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531122320.GB3722@amd \
--to=pavel@ucw.cz \
--cc=devel@acpica.org \
--cc=dmurphy@ti.com \
--cc=erik.schmauss@intel.com \
--cc=jacek.anaszewski@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=nikolaus.voss@loewensteinmedical.de \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox