From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm1-f66.google.com ([209.85.128.66]:50767 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725379AbfFZJma (ORCPT ); Wed, 26 Jun 2019 05:42:30 -0400 Received: by mail-wm1-f66.google.com with SMTP id c66so1378496wmf.0 for ; Wed, 26 Jun 2019 02:42:27 -0700 (PDT) Date: Wed, 26 Jun 2019 11:42:25 +0200 From: Thierry Reding Message-ID: <20190626094225.GA22424@ulmo> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+QahgC5+KEYLbs62" Content-Disposition: inline In-Reply-To: Sender: linux-pwm-owner@vger.kernel.org List-ID: Subject: Re: [pwm:for-next 36/37] drivers/pwm/pwm-fsl-ftm.c:324:3-9: preceding lock on line 305 (fwd) To: Julia Lawall Cc: Patrick Havelange , linux-pwm@vger.kernel.org, kbuild-all@01.org --+QahgC5+KEYLbs62 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 26, 2019 at 10:43:43AM +0200, Julia Lawall wrote: > Hello, >=20 > It seems like there may be missing unlocks on lines 324 and 328. Indeed, the existing "return ret;" in the function seem to have been overlooked when the lock was added. I sent out a patch that should fix this. Thanks for reporting! Thierry > ---------- Forwarded message ---------- > Date: Wed, 26 Jun 2019 12:23:38 +0800 > From: kbuild test robot > To: kbuild@01.org > Cc: Julia Lawall > Subject: [pwm:for-next 36/37] drivers/pwm/pwm-fsl-ftm.c:324:3-9: precedin= g lock > on line 305 >=20 > CC: kbuild-all@01.org > CC: linux-pwm@vger.kernel.org > TO: Patrick Havelange > CC: Thierry Reding >=20 > tree: https://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/li= nux-pwm.git for-next > head: cb8338e4fe3a8278cee91f666d2155a0ce1dd82f > commit: c9aad8a921c23054dc10e783829fe6ee86826101 [36/37] pwm: fsl-ftm: Mo= re relaxed permissions for updating period > :::::: branch date: 9 hours ago > :::::: commit date: 9 hours ago >=20 > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot > Reported-by: Julia Lawall >=20 > >> drivers/pwm/pwm-fsl-ftm.c:324:3-9: preceding lock on line 305 > drivers/pwm/pwm-fsl-ftm.c:328:3-9: preceding lock on line 305 >=20 > # https://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pw= m.git/commit/?id=3Dc9aad8a921c23054dc10e783829fe6ee86826101 > git remote add pwm https://git.kernel.org/pub/scm/linux/kernel/git/thierr= y.reding/linux-pwm.git > git remote update pwm > git checkout c9aad8a921c23054dc10e783829fe6ee86826101 > vim +324 drivers/pwm/pwm-fsl-ftm.c >=20 > b505183b Xiubo Li 2014-02-27 288 > c9aad8a9 Patrick Havelange 2019-06-12 289 static int fsl_pwm_apply(stru= ct pwm_chip *chip, struct pwm_device *pwm, > c9aad8a9 Patrick Havelange 2019-06-12 290 struct pwm_state *newstat= e) > b505183b Xiubo Li 2014-02-27 291 { > b505183b Xiubo Li 2014-02-27 292 struct fsl_pwm_chip *fpc =3D= to_fsl_chip(chip); > c9aad8a9 Patrick Havelange 2019-06-12 293 struct pwm_state *oldstate = =3D &pwm->state; > c9aad8a9 Patrick Havelange 2019-06-12 294 int ret =3D 0; > b505183b Xiubo Li 2014-02-27 295 > c9aad8a9 Patrick Havelange 2019-06-12 296 /* > c9aad8a9 Patrick Havelange 2019-06-12 297 * oldstate to newstate : ac= tion > c9aad8a9 Patrick Havelange 2019-06-12 298 * > c9aad8a9 Patrick Havelange 2019-06-12 299 * disabled to disabled : ig= nore > c9aad8a9 Patrick Havelange 2019-06-12 300 * enabled to disabled : dis= able > c9aad8a9 Patrick Havelange 2019-06-12 301 * enabled to enabled : upda= te settings > c9aad8a9 Patrick Havelange 2019-06-12 302 * disabled to enabled : upd= ate settings + enable > c9aad8a9 Patrick Havelange 2019-06-12 303 */ > b505183b Xiubo Li 2014-02-27 304 > c9aad8a9 Patrick Havelange 2019-06-12 @305 mutex_lock(&fpc->lock); > b505183b Xiubo Li 2014-02-27 306 > c9aad8a9 Patrick Havelange 2019-06-12 307 if (!newstate->enabled) { > c9aad8a9 Patrick Havelange 2019-06-12 308 if (oldstate->enabled) { > c9aad8a9 Patrick Havelange 2019-06-12 309 regmap_update_bits(fpc->re= gmap, FTM_OUTMASK, > c9aad8a9 Patrick Havelange 2019-06-12 310 BIT(pwm->hwpwm), BIT(= pwm->hwpwm)); > c9aad8a9 Patrick Havelange 2019-06-12 311 clk_disable_unprepare(fpc-= >clk[FSL_PWM_CLK_CNTEN]); > c9aad8a9 Patrick Havelange 2019-06-12 312 clk_disable_unprepare(fpc-= >clk[fpc->period.clk_select]); > c9aad8a9 Patrick Havelange 2019-06-12 313 } > c9aad8a9 Patrick Havelange 2019-06-12 314 goto end_mutex; > b505183b Xiubo Li 2014-02-27 315 } > b505183b Xiubo Li 2014-02-27 316 > c9aad8a9 Patrick Havelange 2019-06-12 317 ret =3D fsl_pwm_apply_config= (fpc, pwm, newstate); > c9aad8a9 Patrick Havelange 2019-06-12 318 if (ret) > c9aad8a9 Patrick Havelange 2019-06-12 319 goto end_mutex; > c9aad8a9 Patrick Havelange 2019-06-12 320 /* check if need to enable */ > c9aad8a9 Patrick Havelange 2019-06-12 321 if (!oldstate->enabled) { > c9aad8a9 Patrick Havelange 2019-06-12 322 ret =3D clk_prepare_enable(= fpc->clk[fpc->period.clk_select]); > b505183b Xiubo Li 2014-02-27 323 if (ret) > b505183b Xiubo Li 2014-02-27 @324 return ret; > b505183b Xiubo Li 2014-02-27 325 ret =3D clk_prepare_enable(= fpc->clk[FSL_PWM_CLK_CNTEN]); > b505183b Xiubo Li 2014-02-27 326 if (ret) { > c9aad8a9 Patrick Havelange 2019-06-12 327 clk_disable_unprepare(fpc-= >clk[fpc->period.clk_select]); > b505183b Xiubo Li 2014-02-27 328 return ret; > b505183b Xiubo Li 2014-02-27 329 } > c9aad8a9 Patrick Havelange 2019-06-12 330 regmap_update_bits(fpc->reg= map, FTM_OUTMASK, BIT(pwm->hwpwm), > c9aad8a9 Patrick Havelange 2019-06-12 331 0); > b505183b Xiubo Li 2014-02-27 332 } > b505183b Xiubo Li 2014-02-27 333 > c9aad8a9 Patrick Havelange 2019-06-12 334 end_mutex: > b505183b Xiubo Li 2014-02-27 335 mutex_unlock(&fpc->lock); > b505183b Xiubo Li 2014-02-27 336 return ret; > b505183b Xiubo Li 2014-02-27 337 } > b505183b Xiubo Li 2014-02-27 338 >=20 > :::::: The code at line 324 was first introduced by commit > :::::: b505183b5117ce149c65ae62f8c00e889acafa69 pwm: Add Freescale FTM PW= M driver support >=20 > :::::: TO: Xiubo Li > :::::: CC: Thierry Reding >=20 > --- > 0-DAY kernel test infrastructure Open Source Technology Ce= nter > https://lists.01.org/pipermail/kbuild-all Intel Corpora= tion --+QahgC5+KEYLbs62 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl0TPfwACgkQ3SOs138+ s6HoLRAArC/5NkgXZfz4pJUMP1w8EuLSDHbkUrgM5N871mZXJzJ7LBAZMFCXGYEo 37/0a2AEUMHeSMxmALPukoFPRaPLHjrYKt3QlW84g68WWtWXx0pnVEraRznlHNXz 87JlpSQstL5zYfgqeHYPN4Kjltaz71+yWfNyCZ+jz9aWF9EazLe/GBEJ2/WNnJ26 PO4CNK44DOnP4OYyk6LrzPPGfe8KcONcbhmfvA9k7VHDgbvsdgqOoX9uhWx/QDco /z7ugZyIlfZKjE5nbRkRblbvBaSf0WN0KFcBZQi5jvoe8fJN6XKT04pbEfshRfeJ dlgnxSfPhcHKpsdQzuZLKfzmN6uGcDLGStozRcNPAqYInvcWZ+V+sZOMK0NM2XaM cXVWGTkHHpJ9jpDHXGNd7Di/hwpF4lTJvFY1SY5IBQ4eVkC1J/qepRsGl/Ksj5UV neUGe1Z6Cy1tM6yoCM3ZpR+vVLPdrdrwHGA3YEloCfL+/ypf/V3Gpyj7xDWabvkq TqLrSSahaHTHbCyrzvjFh81ZTEST7SlzKSYrV2Xkek3B82SWa6oDFMIfabhymcBq ZDlrW93qCf7O18GkOwAVSJWRStwvp85OaTLDp0aj3hAHejd9iBZOh8w/GXtka98c 3vgH6qgEgTVOrZZeMo2L0DQkiA3ZcdlSNXrJGfBg0R4VNl7J+6Y= =wnbU -----END PGP SIGNATURE----- --+QahgC5+KEYLbs62--