From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Fabrice Gasnier <fabrice.gasnier@st.com>, linux-pwm@vger.kernel.org
Subject: Re: [PATCH 0/3] pwm: stm32: Minor cleanups
Date: Wed, 16 Oct 2019 10:33:01 +0200 [thread overview]
Message-ID: <20191016083301.63okdbunkq2slevu@pengutronix.de> (raw)
In-Reply-To: <20191016073842.1300297-1-thierry.reding@gmail.com>
On Wed, Oct 16, 2019 at 09:38:39AM +0200, Thierry Reding wrote:
> Hi,
>
> Looking at Fabrice's STM32 patches I noticed that we're now passing the
> breakinput values (u32) into a function via int parameters. The easiest
> way to fix this inconsistency is by just passing a pointer to the break
> input structure. There's some preparatory work here that makes the code
> slightly more readable, in my opinion, but it's really marginal, so I'm
> not terribly thrilled by this series in retrospect.
>
> If nobody else thinks this is a big improvement I'll just scrap it.
I like it. Together with my suggestion to add parameters to the register
offsets I think it's worth the effort.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2019-10-16 8:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 7:38 [PATCH 0/3] pwm: stm32: Minor cleanups Thierry Reding
2019-10-16 7:38 ` [PATCH 1/3] pwm: stm32: Remove clutter from ternary operator Thierry Reding
2019-10-16 8:26 ` Uwe Kleine-König
2019-10-16 9:30 ` Thierry Reding
2019-10-16 7:38 ` [PATCH 2/3] pwm: stm32: Remove confusing bitmask Thierry Reding
2019-10-16 8:31 ` Uwe Kleine-König
2019-10-16 9:50 ` Thierry Reding
2019-10-16 10:20 ` Fabrice Gasnier
2019-10-16 10:52 ` Uwe Kleine-König
2019-10-16 7:38 ` [PATCH 3/3] pwm: stm32: Pass breakinput instead of its values Thierry Reding
2019-10-16 8:33 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016083301.63okdbunkq2slevu@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=fabrice.gasnier@st.com \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox