From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] regulator: pwm: Don't warn on probe deferral Date: Wed, 26 Feb 2020 16:39:05 +0000 Message-ID: <20200226163905.GH4136@sirena.org.uk> References: <20200224144048.6587-1-jonathanh@nvidia.com> <20200224165859.GJ6215@sirena.org.uk> <20200226161757.idpzbs3jmayt7ya6@pengutronix.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nOM8ykUjac0mNN89" Return-path: Content-Disposition: inline In-Reply-To: <20200226161757.idpzbs3jmayt7ya6-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Jon Hunter , Liam Girdwood , Thierry Reding , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-pwm@vger.kernel.org --nOM8ykUjac0mNN89 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 26, 2020 at 05:17:57PM +0100, Uwe Kleine-K=F6nig wrote: > On Mon, Feb 24, 2020 at 04:58:59PM +0000, Mark Brown wrote: > > This then means that there's no way for users to determine why the > > driver has failed to instantiate which can be frustrating. It'd be > > better to at least have some dev_dbg() output when deferring so that > > there's something for people to go on without having to instrument the > > code. > Not printing an error message is quite usual however. I think a generic Usual yet also frustraing. > approach that for example makes the list of devices that should be > retried to probe on the next opportunity inspectable would be nice. That's not really the issue, the bigger issue is trying to figure out why things are stuck - what exactly caused things to fail to instantiate. --nOM8ykUjac0mNN89 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5WnygACgkQJNaLcl1U h9C0mQf+Je+yXfq6X/+OPbN4ayVYuPYE2Jogk4VoMhPMPWkBhvvwkMwaer0tCd3p 3fjLqb+JrBNj/HDM7DuLyAp/gh9KvTeMOvkat713Rtn3N41DhMBykaKzSAHRPRQm P4DZJiD1AjacRHfVyFhW0n2HGbQdDCNivbk+JYVyfrkneoY9+d/LbEaKn+P2aoxY VSPCIPXT9zmdnfym2UVxjAZXvDbY/PjVE6SOlRapjkkUTlyxMINV12lwC3aLM9ni tyLBcvKHXcJMZdh+Mn+YofFOhvCMsC8HbMLTZwNZaAkv9yVpuOEyI7lu7Z87TUpo M7XsPuQZQOrPqpCA3pf3fucaux9Dhg== =RL9B -----END PGP SIGNATURE----- --nOM8ykUjac0mNN89--