From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [RFC PATCH 4/7] dt-bindings: pwm: add description of PWM polarity Date: Wed, 18 Mar 2020 14:29:42 +0200 Message-ID: <20200318122942.GA7833@pendragon.ideasonboard.com> References: <20200317123231.2843297-1-oleksandr.suvorov@toradex.com> <20200317123231.2843297-5-oleksandr.suvorov@toradex.com> <20200317230115.GM2527@pendragon.ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from perceval.ideasonboard.com ([213.167.242.64]:44994 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726546AbgCRM3u (ORCPT ); Wed, 18 Mar 2020 08:29:50 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: Oleksandr Suvorov Cc: devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, Paul Barker , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Marcel Ziswiler , Igor Opaniuk , Philippe Schenker , Rob Herring , linux-kernel@vger.kernel.org Hi Oleksandr, On Wed, Mar 18, 2020 at 01:37:00PM +0200, Oleksandr Suvorov wrote: > On Wed, Mar 18, 2020 at 1:02 AM Laurent Pinchart wrote: > > On Tue, Mar 17, 2020 at 02:32:28PM +0200, Oleksandr Suvorov wrote: > > > Move the description of the PWM signal polarity from > > > , prepare for removing the polarity > > > definition from . > > > > > > Signed-off-by: Oleksandr Suvorov > > > --- > > > > > > include/dt-bindings/pwm/pwm.h | 9 +++++++++ > > > 1 file changed, 9 insertions(+) > > > > > > diff --git a/include/dt-bindings/pwm/pwm.h b/include/dt-bindings/pwm/pwm.h > > > index 6b58caa6385e..c07da2088a61 100644 > > > --- a/include/dt-bindings/pwm/pwm.h > > > +++ b/include/dt-bindings/pwm/pwm.h > > > @@ -10,7 +10,16 @@ > > > #ifndef _DT_BINDINGS_PWM_PWM_H > > > #define _DT_BINDINGS_PWM_PWM_H > > > > > > +/** > > > + * a high signal for the duration of the duty-cycle, followed by a low signal > > > + * for the remainder of the pulse period. > > > + */ > > > > Last time I checked, kernedoc didn't support documenting macros (enums > > are supported). > > That's why I dropped the kerneldoc tags leaving the descriptions only. But you forgot to replace /** with /* :-) Sorry for not being clear about what I meant. > > > #define PWM_POLARITY_NORMAL 0 > > > + > > > +/** > > > + * a low signal for the duration of the duty-cycle, followed by a high signal > > > + * for the remainder of the pulse period. > > > + */ > > > #define PWM_POLARITY_INVERTED (1 << 0) > > > > > > #endif -- Regards, Laurent Pinchart