From: Guru Das Srinagesh <gurus@codeaurora.org>
To: Joe Perches <joe@perches.com>
Cc: linux-pwm@vger.kernel.org,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Subbaraman Narayanamurthy" <subbaram@codeaurora.org>,
linux-kernel@vger.kernel.org,
"Fabrice Gasnier" <fabrice.gasnier@st.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>
Subject: Re: [PATCH v11 08/12] pwm: stm32-lp: Use %llu format specifier for period
Date: Mon, 30 Mar 2020 12:30:08 -0700 [thread overview]
Message-ID: <20200330193008.GA5107@codeaurora.org> (raw)
In-Reply-To: <f957b11abb70457e7bd8c2652d41e7f07024e301.camel@perches.com>
On Fri, Mar 20, 2020 at 03:45:35AM -0700, Joe Perches wrote:
> On Thu, 2020-03-19 at 18:41 -0700, Guru Das Srinagesh wrote:
> > Since the PWM framework is switching struct pwm_args.period's
> > datatype to u64, prepare for this transition by using the right
> > specifier for printing a 64-bit value.
> []
> > diff --git a/drivers/pwm/pwm-stm32-lp.c b/drivers/pwm/pwm-stm32-lp.c
> []
> > @@ -61,7 +61,7 @@ static int stm32_pwm_lp_apply(struct pwm_chip *chip, struct pwm_device *pwm,
> > do_div(div, NSEC_PER_SEC);
> > if (!div) {
> > /* Clock is too slow to achieve requested period. */
> > - dev_dbg(priv->chip.dev, "Can't reach %u ns\n", state->period);
> > + dev_dbg(priv->chip.dev, "Can't reach %llu ns\n", state->period);
> > return -EINVAL;
> > }
>
> Doesn't this introduce a warning now without the
> actual change to the type of state->period?
You're right, it does.
> Likely these patches should either not be separated
> or this should also use a cast to avoid introducing
> intermediate compilation warnings.
Only this patch has this specific issue, so I'll squish it with the
final patch in this series ("pwm: core: Convert period and duty cycle to
u64") that modifies the framework structs. Thanks for pointing this out.
Thank you.
Guru Das.
next prev parent reply other threads:[~2020-03-30 19:30 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 1:41 [PATCH v11 00/12] Convert PWM period and duty cycle to u64 Guru Das Srinagesh
2020-03-20 1:41 ` [PATCH v11 01/12] drm/i915: Use 64-bit division macro Guru Das Srinagesh
2020-03-20 1:41 ` [PATCH v11 02/12] hwmon: pwm-fan: " Guru Das Srinagesh
2020-03-20 1:41 ` [PATCH v11 03/12] ir-rx51: " Guru Das Srinagesh
2020-03-20 1:41 ` [PATCH v11 04/12] pwm: clps711x: Cast period to u32 before use as divisor Guru Das Srinagesh
2020-03-20 17:11 ` Arnd Bergmann
2020-04-07 0:26 ` Guru Das Srinagesh
2020-03-20 1:41 ` [PATCH v11 05/12] pwm: pwm-imx-tpm: Use 64-bit division macro Guru Das Srinagesh
2020-03-20 1:41 ` [PATCH v11 06/12] pwm: imx27: Use 64-bit division macro and function Guru Das Srinagesh
2020-03-20 17:09 ` Arnd Bergmann
2020-03-30 20:43 ` Guru Das Srinagesh
2020-03-31 15:24 ` Arnd Bergmann
2020-03-31 20:20 ` Guru Das Srinagesh
2020-03-31 20:49 ` Thierry Reding
2020-04-02 20:16 ` Guru Das Srinagesh
2020-04-02 20:55 ` Guru Das Srinagesh
2020-04-02 21:16 ` Arnd Bergmann
2020-04-03 17:37 ` Guru Das Srinagesh
2020-04-03 19:13 ` Arnd Bergmann
2020-03-20 1:41 ` [PATCH v11 07/12] pwm: sifive: Use 64-bit division macro Guru Das Srinagesh
2020-03-20 1:41 ` [PATCH v11 08/12] pwm: stm32-lp: Use %llu format specifier for period Guru Das Srinagesh
2020-03-20 10:45 ` Joe Perches
2020-03-30 19:30 ` Guru Das Srinagesh [this message]
2020-03-20 1:41 ` [PATCH v11 09/12] pwm: sun4i: Use 64-bit division function Guru Das Srinagesh
2020-03-20 17:02 ` Arnd Bergmann
2020-03-20 1:41 ` [PATCH v11 10/12] backlight: pwm_bl: " Guru Das Srinagesh
2020-03-20 13:31 ` Lee Jones
2020-03-24 11:07 ` Lee Jones
2020-03-24 12:57 ` Uwe Kleine-König
2020-03-24 13:04 ` Daniel Thompson
2020-03-24 14:24 ` Lee Jones
2020-03-24 14:43 ` Uwe Kleine-König
2020-04-15 9:26 ` Lee Jones
2020-03-20 1:41 ` [PATCH v11 11/12] clk: pwm: Assign u64 divisor to unsigned int before use Guru Das Srinagesh
2020-03-20 17:00 ` Arnd Bergmann
2020-03-20 18:42 ` David Laight
2020-04-07 2:40 ` Guru Das Srinagesh
2020-03-20 1:41 ` [PATCH v11 12/12] pwm: core: Convert period and duty cycle to u64 Guru Das Srinagesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330193008.GA5107@codeaurora.org \
--to=gurus@codeaurora.org \
--cc=alexandre.torgue@st.com \
--cc=fabrice.gasnier@st.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=subbaram@codeaurora.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).