From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guru Das Srinagesh Subject: Re: [PATCH v12 08/11] pwm: sun4i: Use nsecs_to_jiffies to avoid a division Date: Fri, 10 Apr 2020 12:20:41 -0700 Message-ID: <20200410192041.GC21571@codeaurora.org> References: <436e1a50e603eefb24c8e7b2bd7f7e4838b90e12.1586414867.git.gurus@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from alexa-out-sd-02.qualcomm.com ([199.106.114.39]:28012 "EHLO alexa-out-sd-02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726741AbgDJTU5 (ORCPT ); Fri, 10 Apr 2020 15:20:57 -0400 Content-Disposition: inline In-Reply-To: <436e1a50e603eefb24c8e7b2bd7f7e4838b90e12.1586414867.git.gurus@codeaurora.org> Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: linux-pwm@vger.kernel.org, Chen-Yu Tsai Cc: Thierry Reding , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Subbaraman Narayanamurthy , David Collins , linux-kernel@vger.kernel.org, Maxime Ripard , Philipp Zabel On Wed, Apr 08, 2020 at 11:52:37PM -0700, Guru Das Srinagesh wrote: > Since the PWM framework is switching struct pwm_state.period's datatype > to u64, prepare for this transition by using nsecs_to_jiffies() which > does away with the need for a division operation. > > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Cc: Philipp Zabel > > Signed-off-by: Guru Das Srinagesh > --- > drivers/pwm/pwm-sun4i.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c > index 5c677c5..1694e69 100644 > --- a/drivers/pwm/pwm-sun4i.c > +++ b/drivers/pwm/pwm-sun4i.c > @@ -285,7 +285,7 @@ static int sun4i_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, > val = (duty & PWM_DTY_MASK) | PWM_PRD(period); > sun4i_pwm_writel(sun4i_pwm, val, PWM_CH_PRD(pwm->hwpwm)); > sun4i_pwm->next_period[pwm->hwpwm] = jiffies + > - usecs_to_jiffies(cstate.period / 1000 + 1); > + nsecs_to_jiffies(cstate.period + 1000); > > if (state->polarity != PWM_POLARITY_NORMAL) > ctrl &= ~BIT_CH(PWM_ACT_STATE, pwm->hwpwm); > -- Hi Chen-Yu, You had provided your "Acked-by:" [1] for an earlier version of this patch but now that I've revised the patch based on a review comment I received [2], could you please review this patch once again? Thank you. Guru Das. [1] https://www.spinics.net/lists/linux-pwm/msg11755.html [2] https://www.spinics.net/lists/linux-pwm/msg11956.html