From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v3 05/16] mfd: Add support for Kontron sl28cpld management controller Date: Tue, 28 Apr 2020 15:50:49 +0300 Message-ID: <20200428125049.GU185537@smile.fi.intel.com> References: <20200423174543.17161-1-michael@walle.cc> <20200423174543.17161-6-michael@walle.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200423174543.17161-6-michael@walle.cc> Sender: linux-gpio-owner@vger.kernel.org To: Michael Walle Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Lee Jones , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier List-Id: linux-pwm@vger.kernel.org On Thu, Apr 23, 2020 at 07:45:32PM +0200, Michael Walle wrote: > This patch adds core support for the board management controller found > on the SMARC-sAL28 board. It consists of the following functions: > - watchdog > - GPIO controller > - PWM controller > - fan sensor > - interrupt controller ... > obj-$(CONFIG_MFD_STMFX) += stmfx.o > > obj-$(CONFIG_SGI_MFD_IOC3) += ioc3.o > + > +obj-$(CONFIG_MFD_SL28CPLD) += sl28cpld.o Perhaps keep an order? ... > + return devm_mfd_add_devices(dev, -1, sl28cpld_devs, -1 has its own definition. > + ARRAY_SIZE(sl28cpld_devs), NULL, > + i2c->irq, NULL); > +} -- With Best Regards, Andy Shevchenko