From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v3 05/16] mfd: Add support for Kontron sl28cpld management controller Date: Wed, 29 Apr 2020 07:27:25 +0100 Message-ID: <20200429062725.GU3559@dell> References: <20200423174543.17161-1-michael@walle.cc> <20200423174543.17161-6-michael@walle.cc> <20200428125049.GU185537@smile.fi.intel.com> <5e2d486077f9e2ce8bd9b171cf806fd9@walle.cc> <20200428144958.GZ185537@smile.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20200428144958.GZ185537@smile.fi.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Andy Shevchenko Cc: Michael Walle , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier List-Id: linux-pwm@vger.kernel.org On Tue, 28 Apr 2020, Andy Shevchenko wrote: > On Tue, Apr 28, 2020 at 04:43:24PM +0200, Michael Walle wrote: > > Am 2020-04-28 14:50, schrieb Andy Shevchenko: > > > On Thu, Apr 23, 2020 at 07:45:32PM +0200, Michael Walle wrote: > > > > This patch adds core support for the board management controller found > > > > on the SMARC-sAL28 board. It consists of the following functions: > > > > - watchdog > > > > - GPIO controller > > > > - PWM controller > > > > - fan sensor > > > > - interrupt controller > > > > > > ... > > > > > > > obj-$(CONFIG_MFD_STMFX) += stmfx.o > > > > > > > > obj-$(CONFIG_SGI_MFD_IOC3) += ioc3.o > > > > + > > > > +obj-$(CONFIG_MFD_SL28CPLD) += sl28cpld.o > > > > > > Perhaps keep an order? > > > > I don't see any order in that makefile. Looked to me like every new > > file was added at the end. > > Okay, just didn't note from above context. Yes, this is historical. I've been meaning to visit this for ~7 years! -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog