public inbox for linux-pwm@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: dri-devel@lists.freedesktop.org,
	Jingoo Han <jingoohan1@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	Daniel Thompson <daniel.thompson@linaro.org>
Cc: Allison Randal <allison@lohutok.net>,
	Andy Gross <agross@kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	David Airlie <airlied@linux.ie>,
	Douglas Anderson <dianders@chromium.org>,
	Enrico Weigelt <info@metux.net>,
	Jani Nikula <jani.nikula@intel.com>,
	Jonathan Corbet <corbet@lwn.net>, Jyri Sarha <jsarha@ti.com>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	Kefeng Wang <wangkefeng.wang@huawei.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Michael
Subject: [PATCH v1 01/18] drm/omap: display: use devm_of_find_backlight
Date: Thu, 14 May 2020 21:09:44 +0200	[thread overview]
Message-ID: <20200514191001.457441-2-sam@ravnborg.org> (raw)
In-Reply-To: <20200514191001.457441-1-sam@ravnborg.org>

Look up backlight device using devm_of_find_backlight().
This simplifies the code and prevents us from hardcoding
the node name in the driver.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Zheng Bin <zhengbin13@huawei.com>
Cc: Kate Stewart <kstewart@linuxfoundation.org>
Cc: Enrico Weigelt <info@metux.net>
Cc: Allison Randal <allison@lohutok.net>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
---
 .../gpu/drm/omapdrm/displays/panel-dsi-cm.c    | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
index 3484b5d4a91c..faca5c873bde 100644
--- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
+++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
@@ -1163,7 +1163,7 @@ static const struct omap_dss_driver dsicm_dss_driver = {
 static int dsicm_probe_of(struct platform_device *pdev)
 {
 	struct device_node *node = pdev->dev.of_node;
-	struct device_node *backlight;
+	struct backlight_device *backlight;
 	struct panel_drv_data *ddata = platform_get_drvdata(pdev);
 	struct display_timing timing;
 	int err;
@@ -1216,17 +1216,15 @@ static int dsicm_probe_of(struct platform_device *pdev)
 		ddata->vddi = NULL;
 	}
 
-	backlight = of_parse_phandle(node, "backlight", 0);
-	if (backlight) {
-		ddata->extbldev = of_find_backlight_by_node(backlight);
-		of_node_put(backlight);
+	backlight = devm_of_find_backlight(&pdev->dev);
+	if (IS_ERR(backlight))
+		return PTR_ERR(backlight);
 
-		if (!ddata->extbldev)
-			return -EPROBE_DEFER;
-	} else {
-		/* assume native backlight support */
+	/* If no backlight device is found assume native backlight support */
+	if (backlight)
+		ddata->extbldev = backlight;
+	else
 		ddata->use_dsi_backlight = true;
-	}
 
 	/* TODO: ulps */
 
-- 
2.25.1

  reply	other threads:[~2020-05-14 19:09 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14 19:09 [PATCH v1 0/18] backlight updates Sam Ravnborg
2020-05-14 19:09 ` Sam Ravnborg [this message]
2020-05-15  8:24   ` [PATCH v1 01/18] drm/omap: display: use devm_of_find_backlight Tomi Valkeinen
2020-05-17 12:58     ` Sam Ravnborg
2020-05-14 19:09 ` [PATCH v1 02/18] drm/tilcdc: " Sam Ravnborg
2020-05-15  8:25   ` Tomi Valkeinen
2020-05-17 12:58     ` Sam Ravnborg
2020-05-14 19:09 ` [PATCH v1 03/18] video: amba-clcd: " Sam Ravnborg
2020-05-14 19:09 ` [PATCH v1 04/18] backlight: make of_find_backlight static Sam Ravnborg
2020-05-14 19:09 ` [PATCH v1 05/18] backlight: drop backlight_put() Sam Ravnborg
2020-05-14 19:09 ` [PATCH v1 06/18] backlight: make of_find_backlight_by_node() static Sam Ravnborg
2020-05-15 20:42   ` Sam Ravnborg
2020-05-14 19:09 ` [PATCH v1 07/18] backlight: refactor fb_notifier_callback() Sam Ravnborg
2020-05-14 19:09 ` [PATCH v1 08/18] backlight: add backlight_is_blank() Sam Ravnborg
2020-05-14 19:41   ` Daniel Vetter
2020-05-14 19:46     ` Sam Ravnborg
2020-05-14 20:03       ` Daniel Vetter
2020-05-14 19:09 ` [PATCH v1 09/18] backlight: improve backlight_ops documentation Sam Ravnborg
2020-05-14 19:09 ` [PATCH v1 10/18] backlight: improve backlight_properties documentation Sam Ravnborg
2020-05-14 19:09 ` [PATCH v1 11/18] backlight: improve backlight_device documentation Sam Ravnborg
2020-05-14 19:09 ` [PATCH v1 12/18] backlight: document inline functions in backlight.h Sam Ravnborg
2020-05-14 19:09 ` [PATCH v1 13/18] backlight: document enums " Sam Ravnborg
2020-05-14 19:09 ` [PATCH v1 14/18] backlight: remove the unused backlight_bl driver Sam Ravnborg
2020-05-14 19:09 ` [PATCH v1 15/18] backlight: drop extern from prototypes Sam Ravnborg
2020-05-14 19:09 ` [PATCH v1 16/18] backlight: add overview and update existing doc Sam Ravnborg
2020-05-14 19:10 ` [PATCH v1 17/18] backlight: wire up kernel-doc documentation Sam Ravnborg
2020-05-14 19:10 ` [PATCH v1 18/18] backlight: use backlight_is_blank() in all backlight drivers Sam Ravnborg
2020-05-15 20:48 ` [PATCH v1 0/18] backlight updates Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200514191001.457441-2-sam@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=agross@kernel.org \
    --cc=airlied@linux.ie \
    --cc=allison@lohutok.net \
    --cc=b.zolnierkie@samsung.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=corbet@lwn.net \
    --cc=daniel.thompson@linaro.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dianders@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=info@metux.net \
    --cc=jani.nikula@intel.com \
    --cc=jingoohan1@gmail.com \
    --cc=jsarha@ti.com \
    --cc=kstewart@linuxfoundation.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox