From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v2 15/16] backlight: make of_find_backlight_by_node() static Date: Mon, 18 May 2020 20:12:27 +0200 Message-ID: <20200518181227.GC770425@ravnborg.org> References: <20200517190139.740249-1-sam@ravnborg.org> <20200517190139.740249-16-sam@ravnborg.org> <20200518165648.ltgtofjsteyyse4j@holly.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from asavdk4.altibox.net ([109.247.116.15]:42300 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729959AbgERSMe (ORCPT ); Mon, 18 May 2020 14:12:34 -0400 Content-Disposition: inline In-Reply-To: <20200518165648.ltgtofjsteyyse4j@holly.lan> Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: Daniel Thompson Cc: David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Bjorn Andersson , Peter Ujfalusi , Thierry Reding , Lee Jones , Jonathan Corbet , Tomi Valkeinen , Russell King , Andy Gross , Uwe Kleine-Konig , linux-pwm@vger.kernel.org, Michael Hennerich , Bartlomiej Zolnierkiewicz , Jani Nikula , linux-arm-msm@vger.kernel.org, Support Opensource , Jingoo Han On Mon, May 18, 2020 at 05:56:48PM +0100, Daniel Thompson wrote: > On Sun, May 17, 2020 at 09:01:38PM +0200, Sam Ravnborg wrote: > > There are no external users of of_find_backlight_by_node(). > > Make it static so we keep it that way. > > > > v2: > > - drop EXPORT of of_find_backlight_by_node > > > > Signed-off-by: Sam Ravnborg > > Cc: Lee Jones > > Cc: Daniel Thompson > > Cc: Jingoo Han > > Assuming the 0day-ci comments are because some of the patches have > already been sucked up in a different tree then: Correct. For now only drm-misc-next have no users of of_find_backlight_by_node() which is why the other trees failed. > Reviewed-by: Daniel Thompson Thanks for all your reviews! I will shortly (within a few days) address the comments and send out a v3. Is is correct that I assume you or Lee or Jingoo will apply the patches to a backlight tree somewhere when they are ready? If you have a tree you use for backlight patches I can base v3 on that, given that I get a link and have access to pull from it. Sam