From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Sven Van Asbroeck <thesven73@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
YueHaibing <yuehaibing@huawei.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org, kernel-janitors@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] pwm: pca9685: Remove set but not used variable 'pwm'
Date: Sat, 23 May 2020 22:17:30 +0200 [thread overview]
Message-ID: <20200523201730.o7y7pent4hjtgia3@pengutronix.de> (raw)
In-Reply-To: <20190606151111.14237-1-TheSven73@gmail.com>
On Thu, Jun 06, 2019 at 11:11:11AM -0400, Sven Van Asbroeck wrote:
> I was able to test the patch [1] exclusion mechanism without access to actual
> hardware - by giving it a dummy regmap. See patch below.
>
> Test cases (all via sysfs):
> 1. verify requested pwm cannot be requested as gpio
> 2. verify requested gpio cannot be requested as pwm
> 3. verify pwm "all LEDs" cannot be used if pwms/gpios in use
> 4. verify pwms/gpios cannot be requested if pwm "all LEDs" in use
>
> All test cases ok.
> Obviously, I could not test multi-threaded correctness.
>
> [1] https://lkml.org/lkml/2019/6/4/1039
Is this patch still relevant? A patch similar to YueHaibing's one was
merged in the meantime but I guess the underlying problem is still
relevant. Sven, do you care enough to recheck and create a patch on top
of a more recent tree?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
next prev parent reply other threads:[~2020-05-23 20:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-01 3:57 [PATCH -next] pwm: pca9685: Remove set but not used variable 'pwm' YueHaibing
2019-06-01 13:03 ` Sven Van Asbroeck
2019-06-01 16:04 ` Uwe Kleine-König
2019-06-02 14:18 ` Sven Van Asbroeck
2019-06-03 11:40 ` Mika Westerberg
2019-06-03 15:08 ` Sven Van Asbroeck
2019-06-03 15:58 ` Mika Westerberg
2019-06-04 16:01 ` Andy Shevchenko
2019-06-06 15:11 ` Sven Van Asbroeck
2020-05-23 20:17 ` Uwe Kleine-König [this message]
2020-05-24 0:24 ` Sven Van Asbroeck
2020-05-24 10:21 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200523201730.o7y7pent4hjtgia3@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=thesven73@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox