From: David Jander <david@protonic.nl>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>,
Clemens Gruber <clemens.gruber@pqgruber.com>,
Thierry Reding <thierry.reding@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
linux-pwm@vger.kernel.org,
Oleksij Rempel <o.rempel@pengutronix.de>
Subject: Re: [PATCH v2 1/3] drivers: pwm: pwm-pcs9685.c: Make comments more consistent
Date: Wed, 2 Sep 2020 12:07:14 +0200 [thread overview]
Message-ID: <20200902120714.5344af5f@erd988> (raw)
In-Reply-To: <20200902070844.bqb6ic7fju4j6wwm@pengutronix.de>
On Wed, 2 Sep 2020 09:08:44 +0200
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> On Fri, Aug 28, 2020 at 02:14:13PM +0200, David Jander wrote:
> > Make all explanatory comments start with an uppercase char.
> >
> > Signed-off-by: David Jander <david@protonic.nl>
> > ---
> > drivers/pwm/pwm-pca9685.c | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/pwm/pwm-pca9685.c b/drivers/pwm/pwm-pca9685.c
> > index 76cd22bd6614..0f1a3e07e501 100644
> > --- a/drivers/pwm/pwm-pca9685.c
> > +++ b/drivers/pwm/pwm-pca9685.c
> > @@ -91,7 +91,7 @@ static bool pca9685_pwm_test_and_set_inuse(struct pca9685 *pca, int pwm_idx)
> > mutex_lock(&pca->lock);
> > if (pwm_idx >= PCA9685_MAXCHAN) {
> > /*
> > - * "all LEDs" channel:
> > + * "All LEDs" channel:
>
> I'd not replace this one, assuming "all LEDs" is a term from the
> datasheet.
It is not really a "term" in the datasheet. The string "all LEDs" occurs twice
in the datasheet, but AFAICS in both cases it is just a regular sentence that
does not imply a special meaning to this string:
"LED output frequency (all LEDs) typically varies from..."
and
"Remark: When all LED outputs are configured..." (which isn't strictly the
same complete string anyway (missing plural form "s").
So, do you still want me to change it? (no problem with me if you insist in a
v3 patch for this).
> > * pretend already in use if any of the PWMs are requested
> > */
> > if (!bitmap_empty(pca->pwms_inuse, PCA9685_MAXCHAN)) {
> > @@ -100,7 +100,7 @@ static bool pca9685_pwm_test_and_set_inuse(struct pca9685 *pca, int pwm_idx)
Best regards,
--
David Jander
Protonic Holland.
next prev parent reply other threads:[~2020-09-02 10:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 12:14 [PATCH v2 0/3] pwm: pwm-pca9685 Disable unused alternative addresses David Jander
2020-08-28 12:14 ` [PATCH v2 1/3] drivers: pwm: pwm-pcs9685.c: Make comments more consistent David Jander
2020-09-02 7:08 ` Uwe Kleine-König
2020-09-02 10:07 ` David Jander [this message]
2020-08-28 12:14 ` [PATCH v2 2/3] drivers: pwm: pwm-pca9685.c: Use BIT() macro instead of shift David Jander
2020-08-28 12:14 ` [PATCH v2 3/3] drivers: pwm: pwm-pca9685.c: Disable unused alternative addresses David Jander
2020-09-02 7:07 ` Uwe Kleine-König
2020-09-02 10:45 ` David Jander
2020-09-23 12:07 ` [PATCH v2 0/3] pwm: pwm-pca9685 " Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902120714.5344af5f@erd988 \
--to=david@protonic.nl \
--cc=clemens.gruber@pqgruber.com \
--cc=lee.jones@linaro.org \
--cc=linux-pwm@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=s.trumtrar@pengutronix.de \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox