From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: poeschel@lemonage.de
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Lee Jones" <lee.jones@linaro.org>,
"open list:PWM SUBSYSTEM" <linux-pwm@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] pwm: sysfs: Set class on pwm devices
Date: Fri, 2 Oct 2020 14:44:07 +0200 [thread overview]
Message-ID: <20201002124407.GA3348424@kroah.com> (raw)
In-Reply-To: <20201002123048.3073128-1-poeschel@lemonage.de>
On Fri, Oct 02, 2020 at 02:30:47PM +0200, poeschel@lemonage.de wrote:
> + pwm_prop[0] = kasprintf(GFP_KERNEL, "EXPORT=%s",
> + export->child.kobj.name);
Nit, you should use dev_name() here instead of trying to get the raw
kobject name.
thanks,
greg k-h
next prev parent reply other threads:[~2020-10-02 12:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 12:30 [PATCH 1/2] pwm: sysfs: Set class on pwm devices poeschel
2020-10-02 12:32 ` [PATCH 2/2] Documentation: Reflect the changes to pwm sysfs poeschel
2020-10-02 12:44 ` Greg Kroah-Hartman [this message]
2020-10-02 12:46 ` [PATCH 1/2] pwm: sysfs: Set class on pwm devices Greg Kroah-Hartman
2020-10-02 13:08 ` Lars Poeschel
2020-10-02 13:35 ` Greg Kroah-Hartman
2020-10-05 13:42 ` Lars Poeschel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002124407.GA3348424@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=poeschel@lemonage.de \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox