Re: [PATCH v3 09/11] dt-bindings: pwm: Add binding for RPi firmware PWM bus

Nicolas Saenz Julienne
2020-11-04T19:55:28Z

[-- Attachment #1: Type: text/plain, Size: 1108 bytes --]

On Wed, 2020-11-04 at 13:06 -0600, Rob Herring wrote:
> On Wed, 04 Nov 2020 11:39:35 +0100, Nicolas Saenz Julienne wrote:
> > The PWM bus controlling the fan in RPi's official PoE hat can only be
> > controlled by the board's co-processor.
> >
> > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> >
> > ---
> >
> > Changes since v1:
> > - Update bindings to use 2 #pwm-cells
> >
> > .../arm/bcm/raspberrypi,bcm2835-firmware.yaml | 20 +++++++++++++++++++
> > .../pwm/raspberrypi,firmware-pwm.h | 13 ++++++++++++
> > 2 files changed, 33 insertions(+)
> > create mode 100644 include/dt-bindings/pwm/raspberrypi,firmware-pwm.h
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: pwm:#pwm-cells:0:0: 2 was expected

Yes I forgot to update the example...

Regards,
Nicolas

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]