From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C969C5519F for ; Wed, 18 Nov 2020 10:48:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F1B922266 for ; Wed, 18 Nov 2020 10:48:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YmCBR5op" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727811AbgKRKsW (ORCPT ); Wed, 18 Nov 2020 05:48:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726300AbgKRKsW (ORCPT ); Wed, 18 Nov 2020 05:48:22 -0500 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 145B5C0613D4; Wed, 18 Nov 2020 02:48:22 -0800 (PST) Received: by mail-pj1-x1044.google.com with SMTP id h12so846718pjv.2; Wed, 18 Nov 2020 02:48:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kkD7g/WwFQXyV4FNXDvxg3H94RoRFTUfp67Vye/V3PU=; b=YmCBR5opGa4UStGSFPNmuZ3qo58rtcOk6YEWlOYAebbVsa2sa6D/64BK1ntkPUP0CO DQIP133ZBzKm7s48f/4jMxTgRpBgxEB9dN3kF0EBA0vbFT5uEGn7FfE2b662XfGtaPKw EVsgiBaZEutB2xF/EbSAASgFjjryeFXCcpi1QF+20JPUkYkMCoyS7J2IJZs/gSPGIk3B yUtImYJI7H7PGkvBVfhL5uFAbyvOKUtdMXXRkdEylh7CZN6nkwT4OnXDXUaq3qVn0ywT slfnqtF3Bwx46aAE5zhLCgKodF9oPV75qwOblXwr76guCJSb0+HeUVaIPSvl34e68SSI 6NNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kkD7g/WwFQXyV4FNXDvxg3H94RoRFTUfp67Vye/V3PU=; b=ctdZ2d5ayjmVY2DWLWVnsTfLSiAFtslLTblw/j/ZMn24QPtmyH78qNqs6R6zkjpauW cse0tkHwdmeLDLNDMEo1admoBvuwt+Wvg7hJtaRar1pkfYEcvTmmcQBN/10KQOtyOHkG 4gzU9asyAsY3v/xazu69wmCdXMX7zqmu3+2jirOlFCpZvcCZR2w6EyESmvdGHy5VIh4F mbkA7ARa9foO2DFd4mbkDAB/7c1EJrpdbjrKigXZfncs7K58CEKVDLzj2kHC91mZBvAc E0Lue4jk+5tErqsBA5nAdw073DgqyxZ4CO8f0lOt0M3mAR4ObU3NK0LCpWe/MohHRfb+ EZjw== X-Gm-Message-State: AOAM533/cYp9SQLXREFHbfg7suv7+coLym5X9hK6XwE7d9K2r4PvVyHm jU/tnjQLdb1S8Sy6txbs/2M= X-Google-Smtp-Source: ABdhPJxiSVps73UA6RWeEZ8Gop1SI1TB5RWAxfe9IxDY6WzcxsAKFxNM2r9waVHrGW7g7NOYdGDbww== X-Received: by 2002:a17:90a:1902:: with SMTP id 2mr3423275pjg.177.1605696501443; Wed, 18 Nov 2020 02:48:21 -0800 (PST) Received: from manjaro.domain.name ([202.142.93.91]) by smtp.gmail.com with ESMTPSA id o67sm24480994pfb.109.2020.11.18.02.48.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2020 02:48:20 -0800 (PST) From: Soham Biswas To: thierry.reding@gmail.com Cc: lee.jones@linaro.org, u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, Soham Biswas Subject: [PATCH] pwm: core: Use octal permission Date: Wed, 18 Nov 2020 16:17:30 +0530 Message-Id: <20201118104730.4270-1-sohambiswas41@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201117175452.26914-1-sohambiswas41@gmail.com> References: <20201117175452.26914-1-sohambiswas41@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org Fixes the following warning generated by checkpatch: drivers/pwm/core.c:1341: WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +debugfs_create_file("pwm", S_IFREG | S_IRUGO, NULL, NULL, &pwm_debugfs_fops); Signed-off-by: Soham Biswas --- drivers/pwm/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 1f16f5365d3c..a8eff4b3ee36 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -1338,7 +1338,7 @@ DEFINE_SEQ_ATTRIBUTE(pwm_debugfs); static int __init pwm_debugfs_init(void) { - debugfs_create_file("pwm", S_IFREG | S_IRUGO, NULL, NULL, + debugfs_create_file("pwm", S_IFREG | 0444, NULL, NULL, &pwm_debugfs_fops); return 0; -- 2.29.2