From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B5CEC64E90 for ; Wed, 18 Nov 2020 13:59:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0AA372078D for ; Wed, 18 Nov 2020 13:59:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OMtLm8us" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726630AbgKRN7E (ORCPT ); Wed, 18 Nov 2020 08:59:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726531AbgKRN7D (ORCPT ); Wed, 18 Nov 2020 08:59:03 -0500 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5833DC0613D4; Wed, 18 Nov 2020 05:59:02 -0800 (PST) Received: by mail-pg1-x544.google.com with SMTP id w4so1228118pgg.13; Wed, 18 Nov 2020 05:59:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rimqJqRJwrIOhYO+VNFNI9V0S06+Ty+IA7MjQW8qayk=; b=OMtLm8usqAAVY/VNYkTB6P7jvDPV2p343CObgLyaTlQB8TMHMoYBAkpy8twiOLHXdB 6LvgZACiq+0O99TVoYZbd2/A8qRW+pxe/6n71ajxgEM6FdusqWu/cQ8/gVa/s4FW5iKL xa67gAzignJp/NsjKQQxSemAKVG/JVqduRqpZUPqpFb1hTxMYMgIiE+pryh/kS5NLr54 fd+DrlAeCt2CZ5A98lpp/9YqMJzuAOtbKzxFv3sBII33dUYPH/Np+TXETMNRpBayQUrT 8oXO3T0yNk2pu8CBenVfMha86S4/76NQXl5S/rRTQTFCOWylTb01/5yyruJimAgD1Ad9 FVzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rimqJqRJwrIOhYO+VNFNI9V0S06+Ty+IA7MjQW8qayk=; b=qaTcB7wS2AHEmLdebVAB9n6A/wZGtPaP7rOg1cbRCGZCgh7fgrScBihnsfUCxXlVFJ fbY549hE8b1FH99aC8JKugjk+XtVxRJ3lIVAI9t6m3dVHrWXDdsiP6jX5U4Ba5xXTksb AGUIhoHRl20n6pQnbQ3aO/sBxYI6fmVdHVJUqGi4+H2F0hDx5RZcVsbkN1G5J70u78PI YxQWU2X2pGqmi5y0hIEBLsq36Ys/PktqDZKPzXsfvFBxO01eYOFETA8A+QLWDyzIljaJ uKHbFIaoBGKjKX5ZNTL39bLGAAGqhPXpedlPUYdBe3s5R3MfikPF1cqKn5KU5WrYxp0t UXVQ== X-Gm-Message-State: AOAM530A9UZGsyRrlrH40Y/3WGGl4ariDPg9Z+IJPR8nuKW0n4EAyBh5 C1XsTLTk4dohKXYMd2vwjRT3ob5zo39T+Bil/dY= X-Google-Smtp-Source: ABdhPJy8Kmmh46lqVfebUl1itC0FZKVnwySpk74pfY2eWFJfYdoz11ICVdAdD7FKHNaLse5RR3GW7A== X-Received: by 2002:a65:4485:: with SMTP id l5mr8195872pgq.10.1605707941881; Wed, 18 Nov 2020 05:59:01 -0800 (PST) Received: from manjaro.domain.name ([202.142.93.91]) by smtp.gmail.com with ESMTPSA id a17sm23269919pga.56.2020.11.18.05.58.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2020 05:59:01 -0800 (PST) From: Soham Biswas To: thierry.reding@gmail.com Cc: lee.jones@linaro.org, u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, Soham Biswas Subject: [PATCH] pwm: core: Use octal permission Date: Wed, 18 Nov 2020 19:28:35 +0530 Message-Id: <20201118135835.18395-1-sohambiswas41@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201117175452.26914-1-sohambiswas41@gmail.com> References: <20201117175452.26914-1-sohambiswas41@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org Permission bits are easier readable in octal than with using the symbolic names. Fixes the following warning generated by checkpatch: drivers/pwm/core.c:1341: WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +debugfs_create_file("pwm", S_IFREG | S_IRUGO, NULL, NULL, &pwm_debugfs_fops); Signed-off-by: Soham Biswas --- drivers/pwm/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 1f16f5365d3c..a8eff4b3ee36 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -1338,7 +1338,7 @@ DEFINE_SEQ_ATTRIBUTE(pwm_debugfs); static int __init pwm_debugfs_init(void) { - debugfs_create_file("pwm", S_IFREG | S_IRUGO, NULL, NULL, + debugfs_create_file("pwm", S_IFREG | 0444, NULL, NULL, &pwm_debugfs_fops); return 0; -- 2.29.2