Re: [PATCH v2] pwm: core: Use octal permission

Uwe Kleine-König
2020-11-18T12:43:23Z

[-- Attachment #1: Type: text/plain, Size: 888 bytes --]

[added "v2" to the subject, would have been better if you had already
done that. I don't know if/how this confuses tools like b4 and patchwork]

Hello,

On Wed, Nov 18, 2020 at 04:17:30PM +0530, Soham Biswas wrote:
> Fixes the following warning generated by checkpatch:
>
> drivers/pwm/core.c:1341: WARNING: Symbolic permissions 'S_IRUGO' are
> not preferred. Consider using octal permissions '0444'.
>
> +debugfs_create_file("pwm", S_IFREG | S_IRUGO, NULL, NULL,
> &pwm_debugfs_fops);

something like: "Permission bits are easier readable in octal than with
using the symbolic names." in the commit log would be good for those of
us who missed why this was added to checkpatch.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]