From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Marten Lindahl <martenli@axis.com>
Cc: "Mårten Lindahl" <marten.lindahl@axis.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Lee Jones" <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-pwm@vger.kernel.org,
kernel@axis.com
Subject: Re: [PATCH v2] pwm: pwm-samsung: Trigger manual update when disabling PWM
Date: Thu, 9 Sep 2021 11:31:36 +0200 [thread overview]
Message-ID: <20210909093136.cusr6sg2tdo47k3z@pengutronix.de> (raw)
In-Reply-To: <20210909092409.GA11367@axis.com>
[-- Attachment #1: Type: text/plain, Size: 690 bytes --]
Hello Marten,
On Thu, Sep 09, 2021 at 11:24:10AM +0200, Marten Lindahl wrote:
> If I only move up the definition of __pwm_samsung_manual_update, and
> leave pwm_samsung_manual_update at its place, the patch becomes quite
> straightforward and overviewable. Or do you prefer to group the definitions
> of those two functions together?
No strong preference. I found it natural to keep
__pwm_samsung_manual_update and pwm_samsung_manual_update together, but
I wouldn't object your suggestion either.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-09-09 9:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 15:59 [PATCH v2] pwm: pwm-samsung: Trigger manual update when disabling PWM Mårten Lindahl
2021-09-09 8:05 ` Uwe Kleine-König
2021-09-09 9:24 ` Marten Lindahl
2021-09-09 9:31 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210909093136.cusr6sg2tdo47k3z@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=kernel@axis.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=marten.lindahl@axis.com \
--cc=martenli@axis.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).